From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Alexander Graf <agraf@suse.de>
Cc: "qemu-ppc@nongnu.org list:PowerPC" <qemu-ppc@nongnu.org>,
Paul Mackerras <paulus@samba.org>,
"qemu-devel@nongnu.org qemu-devel" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH -V3 1/4] target-ppc: Update slb array with correct index values.
Date: Mon, 26 Aug 2013 17:46:25 +0530 [thread overview]
Message-ID: <87haecejfq.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <A61F2E9C-EAFE-4465-9556-7603AC035535@suse.de>
Alexander Graf <agraf@suse.de> writes:
> On 26.08.2013, at 08:46, Aneesh Kumar K.V wrote:
>
>> Alexander Graf <agraf@suse.de> writes:
>>
....
>>>
>>>> + */
>>>> + memset(env->slb, 0, 64 * sizeof(ppc_slb_t));
>>>
>>> Can't we use ARRAY_SIZE here and below?
>>
>> I was thinking we want to be explicit there saying we are zeroing out all
>> the 64 entries. I could do sizeof(env->slb).
>
> Yup, that works too. In the loop below s/64/ARRAY_SIZE(env->slb)/ should work too I think.
>
Updated with the above change.
-aneesh
next prev parent reply other threads:[~2013-08-26 12:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1377235210-27093-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
[not found] ` <1377235210-27093-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
2013-08-25 18:32 ` [Qemu-devel] [PATCH -V3 1/4] target-ppc: Update slb array with correct index values Alexander Graf
2013-08-26 6:46 ` Aneesh Kumar K.V
2013-08-26 10:31 ` Alexander Graf
2013-08-26 12:16 ` Aneesh Kumar K.V [this message]
[not found] ` <1377235210-27093-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
2013-08-25 18:32 ` [Qemu-devel] [PATCH -V3 2/4] target-ppc: Fix page table lookup with kvm enabled Alexander Graf
2013-08-25 21:13 ` [Qemu-devel] [Qemu-ppc] " Benjamin Herrenschmidt
2013-08-26 3:33 ` Aneesh Kumar K.V
2013-08-26 3:45 ` Benjamin Herrenschmidt
2013-08-26 5:46 ` [Qemu-devel] " Aneesh Kumar K.V
2013-08-26 11:09 ` Alexander Graf
2013-08-26 12:18 ` Aneesh Kumar K.V
[not found] ` <1377235210-27093-4-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
2013-08-25 18:32 ` [Qemu-devel] [PATCH -V3 3/4] target-ppc: Check for error on address translation in memsave command Alexander Graf
2013-08-25 22:17 ` Andreas Färber
2013-08-26 12:20 ` Aneesh Kumar K.V
2013-08-26 12:22 ` Andreas Färber
2013-08-26 13:22 ` Luiz Capitulino
[not found] ` <1377235210-27093-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
2013-08-25 18:33 ` [Qemu-devel] [PATCH -V3 4/4] target-ppc: Use #define for max slb entries Alexander Graf
2013-08-25 22:20 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87haecejfq.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=paulus@samba.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).