From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpHY9-00017P-HR for qemu-devel@nongnu.org; Wed, 19 Jun 2013 08:31:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpHY8-0001Cv-EY for qemu-devel@nongnu.org; Wed, 19 Jun 2013 08:31:45 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:50270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpHY8-0000qK-8T for qemu-devel@nongnu.org; Wed, 19 Jun 2013 08:31:44 -0400 Received: from /spool/local by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 19 Jun 2013 06:31:17 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 9400119D8036 for ; Wed, 19 Jun 2013 06:31:03 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5JCV0aT105708 for ; Wed, 19 Jun 2013 06:31:05 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5JCUxDS024099 for ; Wed, 19 Jun 2013 06:30:59 -0600 From: Anthony Liguori In-Reply-To: <1371627895-27046-2-git-send-email-armbru@redhat.com> References: <1371627895-27046-1-git-send-email-armbru@redhat.com> <1371627895-27046-2-git-send-email-armbru@redhat.com> Date: Wed, 19 Jun 2013 07:30:49 -0500 Message-ID: <87hagu1dvq.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 1/2] libqtest: Plug fd and memory leaks in qtest_quit() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Markus Armbruster writes: > Signed-off-by: Markus Armbruster Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > tests/libqtest.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tests/libqtest.c b/tests/libqtest.c > index 879ffe9..bb82069 100644 > --- a/tests/libqtest.c > +++ b/tests/libqtest.c > @@ -171,12 +171,16 @@ void qtest_quit(QTestState *s) > waitpid(pid, &status, 0); > } > > + close(s->fd); > + close(s->qmp_fd); > + g_string_free(s->rx, true); > unlink(s->pid_file); > unlink(s->socket_path); > unlink(s->qmp_socket_path); > g_free(s->pid_file); > g_free(s->socket_path); > g_free(s->qmp_socket_path); > + g_free(s); > } > > static void socket_sendf(int fd, const char *fmt, va_list ap) > -- > 1.7.11.7