Re: [Qemu-devel] [PATCH 00/11] build ACPI MADT for fw_cfg clients

[Anthony Liguori <aliguori@us.ibm.com>]

Laszlo Ersek <lersek@redhat.com> writes:

> On 03/21/13 00:23, Laszlo Ersek wrote:
>> This series reworks the internals of the -acpitable command line option,
>> and if that option is not specified, produces the APIC (MADT) table
>> inside qemu, to be consumed over fw_cfg (alongside the DSDT).
>
>> Laszlo Ersek (11):
>>   strip some whitespace
>>   change element type from "char" to "unsigned char" in ACPI table data
>>   acpi_table_add(): report fatal errors through an internal Error
>>     object
>>   qapi schema: add AcpiTableOptions
>>   acpi_table_add(): accept QemuOpts and parse it with OptsVisitor
>>   acpi_table_add(): extract and reimplement internals
>>   like acpi_table_install(), acpi_table_add() should propagate Errors
>>   extract/unify the constant 0xfee00000 as APIC_DEFAULT_ADDRESS
>>   Introduce IO_APIC_DEFAULT_ADDRESS for 0xfec00000
>>   pc_acpi_init(): don't bail as soon as failing to find default DSDT
>>   i386/pc: build ACPI MADT for fw_cfg clients
>
> Any chance patches 01 to 09 could be considered? Esp. 06 which removes
> an out-of-bounds access (an innocent-looking one, admittedly).
>
> I'm OK too if the series is dropped (patch 11 was the main motivation,
> but the interface that it extends was deemed unsuitable going forward on
> the seabios list). I'd just like to hear the maintainer with
> jurisdiction say the NAK. ("Too expensive even to review for too little
> gain" is a good reason.)

The whole thing looks pretty nice to me.  I'll merge the full series in
a day or so unless anyone objects.

This is an under maintained area of QEMU so it's very nice to see
improvements!

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

>
> Thanks
> Laszlo