From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1mBY-0002g7-Nm for qemu-devel@nongnu.org; Sat, 02 Feb 2013 18:07:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U1mBX-00016S-EN for qemu-devel@nongnu.org; Sat, 02 Feb 2013 18:07:48 -0500 Received: from e8.ny.us.ibm.com ([32.97.182.138]:45113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1mBX-00016O-AR for qemu-devel@nongnu.org; Sat, 02 Feb 2013 18:07:47 -0500 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 2 Feb 2013 18:07:47 -0500 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id CEC0B6E803F for ; Sat, 2 Feb 2013 18:07:42 -0500 (EST) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r12N7hmE305192 for ; Sat, 2 Feb 2013 18:07:44 -0500 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r12N7hs2012981 for ; Sat, 2 Feb 2013 16:07:43 -0700 From: Anthony Liguori In-Reply-To: <1359835708.1968.3.camel@localhost> References: <510C2327.5080707@msgid.tls.msk.ru> <510C25F2.8000406@msgid.tls.msk.ru> <87fw1fbwk7.fsf@codemonkey.ws> <510C28BD.7050701@msgid.tls.msk.ru> <87zjznagbd.fsf@codemonkey.ws> <510D09C2.6050905@redhat.com> <1359835708.1968.3.camel@localhost> Date: Sat, 02 Feb 2013 17:07:39 -0600 Message-ID: <87halu1fic.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vadim Rozenfeld , yvugenfi@redhat.com, Jason Wang Cc: Michael Tokarev , qemu-devel , "Michael S. Tsirkin" Vadim Rozenfeld writes: > On Sat, 2013-02-02 at 20:42 +0800, Jason Wang wrote: >> >> Have a look at this issue. It was caused by multiqueue patch who adds a >> new field to virtio_net_cfg. Not sure multiqueue is the root cause since >> I also find even w/o multiqueue, adding any new field to virtio_net_cfg >> will break windows guest. Haven't had a clue on this, will continue >> investigate. > > cc'ing Yan, our NDIS guy. If it helps, mq changes the config size from 8 to 16 bytes. If the driver was making an assumption about an 8-byte config size, that's likely what the problem is. Regards, Anthony Liguori > Thank you, > Vadim. >> > >> >>> Regards, >> >>> >> >>> Anthony Liguori >> >>> >> >>>> commit fed699f9ca6ae8a0fb62803334cf46fa64d1eb91 >> >>>> Author: Jason Wang >> >>>> Date: Wed Jan 30 19:12:39 2013 +0800 >> >>>> >> >>>> virtio-net: multiqueue support >> >>>> >> >>>> This patch implements both userspace and vhost support for multiple queue >> >>>> virtio-net (VIRTIO_NET_F_MQ). This is done by introducing an array of >> >>>> VirtIONetQueue to VirtIONet. >> >>>> >> >>>> Signed-off-by: Jason Wang >> >>>> Signed-off-by: Anthony Liguori >> >>>> >> >>>> After this commit, win guest (winXP and win7) shows yellow >> >>>> exclamation sign and is unable to start the device with >> >>>> code 10. >> >>>> >> >>>> FWIW. I'm not sure it is a good idea to make a release with >> >>>> such a breakage, even rc0. >> >>>> >> >>>> Thanks, >> >>>> >> >>>> /mjt >> > >>