From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvwDM-0007sm-1N for qemu-devel@nongnu.org; Mon, 30 Jul 2012 16:05:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SvwDI-0005mA-6N for qemu-devel@nongnu.org; Mon, 30 Jul 2012 16:05:15 -0400 Received: from e3.ny.us.ibm.com ([32.97.182.143]:51778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SvwDI-0005m5-2e for qemu-devel@nongnu.org; Mon, 30 Jul 2012 16:05:12 -0400 Received: from /spool/local by e3.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 30 Jul 2012 16:05:11 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 72BD338C8081 for ; Mon, 30 Jul 2012 16:05:07 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6UK55Sd428706 for ; Mon, 30 Jul 2012 16:05:06 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6UK53Pi010378 for ; Mon, 30 Jul 2012 17:05:04 -0300 From: Anthony Liguori In-Reply-To: <20120730165809.2788f1a1@doriath.home> References: <1343554983-4195-1-git-send-email-owasserm@redhat.com> <1343554983-4195-3-git-send-email-owasserm@redhat.com> <874nopc9tr.fsf@codemonkey.ws> <20120730165809.2788f1a1@doriath.home> Date: Mon, 30 Jul 2012 15:04:57 -0500 Message-ID: <87haspnhg6.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: peter.maydell@linaro.org, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, Orit Wasserman , chegu_vinod@hp.com, avi@redhat.com, pbonzini@redhat.com, eblake@redhat.com Luiz Capitulino writes: > On Mon, 30 Jul 2012 14:45:04 -0500 > Anthony Liguori wrote: > >> Orit Wasserman writes: >> >> > The management can enable/disable a capability for the next migration by using >> > migrate_set_parameter command. >> > The management can query the current migration capabilities using >> > query-migrate-parameters >> > >> > Signed-off-by: Orit Wasserman >> > Signed-off-by: Juan Quintela >> >> We have a way to add new commands. Let's not invent a new one. >> Otherwise every subsystem would have it's own approach to querying >> what's available. > > I think it does make sense for setting/getting migration's capabilities, which > are just booleans. And that's what the commands currently do, btw. > > I'd only recommend to rename them to migrate_set_capability > query-migrate-capabilities. If that's the intent, it should take/return a list of capabilities (expressed as an enum). Regards, Anthony Liguori