From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MsLga-00015h-IG
	for qemu-devel@nongnu.org; Mon, 28 Sep 2009 15:15:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MsLgV-00014q-Hc
	for qemu-devel@nongnu.org; Mon, 28 Sep 2009 15:14:59 -0400
Received: from [199.232.76.173] (port=48166 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MsLgV-00014n-62
	for qemu-devel@nongnu.org; Mon, 28 Sep 2009 15:14:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56385)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1MsLgU-0003gc-5t
	for qemu-devel@nongnu.org; Mon, 28 Sep 2009 15:14:55 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8SJEk37005867
	for <qemu-devel@nongnu.org>; Mon, 28 Sep 2009 15:14:46 -0400
Subject: Re: [Qemu-devel] [PATCH 0/6] Fix pci_add not to exit on error & other
	fixes
References: <cover.1253843232.git.armbru@redhat.com>
	<1254153903.2802.3796.camel@blaa> <1254154613.2802.3800.camel@blaa>
From: Markus Armbruster <armbru@redhat.com>
Date: Mon, 28 Sep 2009 21:14:45 +0200
In-Reply-To: <1254154613.2802.3800.camel@blaa> (Mark McLoughlin's message of
	"Mon\, 28 Sep 2009 17\:16\:53 +0100")
Message-ID: <87hbumnaoq.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>
Cc: qemu-devel@nongnu.org

Mark McLoughlin <markmc@redhat.com> writes:

> On Mon, 2009-09-28 at 17:05 +0100, Mark McLoughlin wrote:
>> On Fri, 2009-09-25 at 03:53 +0200, Markus Armbruster wrote:
>> > Markus Armbruster (6):
>> >   Fix pci_vga_init() not to ignore bus argument
>> >   Fix pci_add storage not to exit on bad first argument
>> >   Make it obvious that pci_nic_init() can't fail
>> >   Fix pci_add nic not to exit on bad model
>> >   pci_create() is now unused, remove it
>> >   Rename pci_create_noinit() to pci_create()
>> 
>> Looks like a good series to me too
>> 
>> Acked-by: Mark McLoughlin <markmc@redhat.com>
>
> Oh, and IMHO, at least patches 3 and 4 makes sense for stable-0.11;
> patch 4 just needs an update for e1000 being the default model now
>
> Patch 2 might make sense too with a little massaging

Yes.  The others are mere cleanup, doubt they're appropriate for stable.