From: Markus Armbruster <armbru@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] monitor: Drop pci_addr prefix from hotplug commands
Date: Fri, 26 Jun 2009 19:44:50 +0200 [thread overview]
Message-ID: <87hby2opnx.fsf@pike.pond.sub.org> (raw)
In-Reply-To: <4A43F450.9060207@web.de> (Jan Kiszka's message of "Fri\, 26 Jun 2009 00\:04\:00 +0200")
Jan Kiszka <jan.kiszka@web.de> writes:
> The "pci_addr=" prefix currently required by pci_add/remove and
> drive_add has no practical use. Drop it, but still silently accept it
> for backward compatibility.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
It's backward compatible, just not bug-compatible: junk like
a=b,pci_addr=auto,c=d no longer works. Fine with me.
I wish we could use the addr= from the options argument and be done
with it. Not backward compatible, so no go.
Acked-by: Markus Armbruster <armbru@redhat.com>
prev parent reply other threads:[~2009-06-26 19:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 22:04 [Qemu-devel] [PATCH 1/2] monitor: Drop pci_addr prefix from hotplug commands Jan Kiszka
2009-06-26 17:44 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hby2opnx.fsf@pike.pond.sub.org \
--to=armbru@redhat.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).