From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MKHGh-00041e-8Q for qemu-devel@nongnu.org; Fri, 26 Jun 2009 15:39:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MKHGc-00040P-Pm for qemu-devel@nongnu.org; Fri, 26 Jun 2009 15:39:26 -0400 Received: from [199.232.76.173] (port=41756 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MKHGc-00040K-LL for qemu-devel@nongnu.org; Fri, 26 Jun 2009 15:39:22 -0400 Received: from mx2.redhat.com ([66.187.237.31]:40463) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MKHGc-000365-44 for qemu-devel@nongnu.org; Fri, 26 Jun 2009 15:39:22 -0400 Subject: Re: [Qemu-devel] [PATCH 1/2] monitor: Drop pci_addr prefix from hotplug commands References: <4A43F450.9060207@web.de> From: Markus Armbruster Date: Fri, 26 Jun 2009 19:44:50 +0200 In-Reply-To: <4A43F450.9060207@web.de> (Jan Kiszka's message of "Fri\, 26 Jun 2009 00\:04\:00 +0200") Message-ID: <87hby2opnx.fsf@pike.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel Jan Kiszka writes: > The "pci_addr=" prefix currently required by pci_add/remove and > drive_add has no practical use. Drop it, but still silently accept it > for backward compatibility. > > Signed-off-by: Jan Kiszka It's backward compatible, just not bug-compatible: junk like a=b,pci_addr=auto,c=d no longer works. Fine with me. I wish we could use the addr= from the options argument and be done with it. Not backward compatible, so no go. Acked-by: Markus Armbruster