Re: [Qemu-devel] [PATCH] RFC: fix fcntl support in linux-user - new try

[Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>]

Laurent Vivier <laurent@vivier.eu> writes:

Hi,

>>Hi,
>>
>>This is a new try to fix the fcntl support in linux-user. I tried to
>>adress all comments but as the previous version is several weeks old,
>>it's possible that I've missed some.
>>
>>This patch doesn't handle linux specific fcntl flags. My plan is to get
>>this version of the patch reviewed/fixed and then, add them if wanted.
>>
>>Thanks,
>>Arnaud
>>
>
> I didn't follow the discussion, but for target_to_host_fnctl_cmd(), why not an array like host_to_target_signal_table[], in linux-user/signal.c ?

See the thread at
http://lists.gnu.org/archive/html/qemu-devel/2009-04/msg01208.html.

I was using an array but the problem is that it doesn't check for all
possible wrong input. For instance you may end up passing 0 as command
which is not want you want if the flag is not F_DUPFD.


Arnaud