From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MBq5s-000547-Jb
	for qemu-devel@nongnu.org; Wed, 03 Jun 2009 09:01:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MBq5o-00053F-Gn
	for qemu-devel@nongnu.org; Wed, 03 Jun 2009 09:01:22 -0400
Received: from [199.232.76.173] (port=35059 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MBq5n-00052g-8c
	for qemu-devel@nongnu.org; Wed, 03 Jun 2009 09:01:20 -0400
Received: from lechat.rtp-net.org ([88.191.19.38]:34242)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <arnaud.patard@rtp-net.org>) id 1MBq5l-0006Uc-8B
	for qemu-devel@nongnu.org; Wed, 03 Jun 2009 09:01:17 -0400
From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
Subject: Re: [Qemu-devel] [PATCH] RFC: fix fcntl support in linux-user - new
	try
References: <25533456.1943631244033278919.JavaMail.servlet@kundenserver>
Date: Wed, 03 Jun 2009 15:09:31 +0200
In-Reply-To: <25533456.1943631244033278919.JavaMail.servlet@kundenserver>
	(Laurent Vivier's message of "Wed\, 03 Jun 2009 14\:47\:58 +0200")
Message-ID: <87hbyxv4z8.fsf@lechat.rtp-net.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <laurent@vivier.eu>
Cc: qemu-devel@nongnu.org

Laurent Vivier <laurent@vivier.eu> writes:

Hi,

>>Hi,
>>
>>This is a new try to fix the fcntl support in linux-user. I tried to
>>adress all comments but as the previous version is several weeks old,
>>it's possible that I've missed some.
>>
>>This patch doesn't handle linux specific fcntl flags. My plan is to get
>>this version of the patch reviewed/fixed and then, add them if wanted.
>>
>>Thanks,
>>Arnaud
>>
>
> I didn't follow the discussion, but for target_to_host_fnctl_cmd(), why not an array like host_to_target_signal_table[], in linux-user/signal.c ?

See the thread at
http://lists.gnu.org/archive/html/qemu-devel/2009-04/msg01208.html.

I was using an array but the problem is that it doesn't check for all
possible wrong input. For instance you may end up passing 0 as command
which is not want you want if the flag is not F_DUPFD.


Arnaud