From: Juan Quintela <quintela@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, "Peter Xu" <peterx@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v3 02/11] tests/qtest: Introduce qtest_init_with_env
Date: Wed, 18 Oct 2023 16:13:32 +0200 [thread overview]
Message-ID: <87il7481df.fsf@secure.mitica> (raw)
In-Reply-To: <20231018140736.3618-3-farosas@suse.de> (Fabiano Rosas's message of "Wed, 18 Oct 2023 11:07:27 -0300")
Fabiano Rosas <farosas@suse.de> wrote:
> Add a version of qtest_init() that takes an environment variable
> containing the path of the QEMU binary. This allows tests to use more
> than one QEMU binary.
>
> If no variable is provided or the environment variable does not exist,
> that is not an error. Fallback to using QTEST_QEMU_BINARY.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
But I need that thomas or someone else also agrees.
next prev parent reply other threads:[~2023-10-18 14:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 14:07 [PATCH v3 00/11] tests/migration-test: Allow testing older machine types Fabiano Rosas
2023-10-18 14:07 ` [PATCH v3 01/11] tests/qtest: Allow qtest_qemu_binary to use a custom environment variable Fabiano Rosas
2023-10-18 14:07 ` [PATCH v3 02/11] tests/qtest: Introduce qtest_init_with_env Fabiano Rosas
2023-10-18 14:13 ` Juan Quintela [this message]
2023-10-18 14:07 ` [PATCH v3 03/11] tests/qtest: Allow qtest_get_machines to use an alternate QEMU binary Fabiano Rosas
2023-10-18 14:07 ` [PATCH v3 04/11] tests/qtest: Introduce qtest_has_machine_with_env Fabiano Rosas
2023-10-18 14:07 ` [PATCH v3 05/11] tests/qtest: Introduce qtest_resolve_machine_alias Fabiano Rosas
2023-10-18 14:07 ` [PATCH v3 06/11] tests/qtest/migration: Introduce find_common_machine_version Fabiano Rosas
2023-10-18 14:07 ` [PATCH v3 07/11] tests/qtest/migration: Define a machine for all architectures Fabiano Rosas
2023-10-18 14:07 ` [PATCH v3 08/11] tests/qtest/migration: Specify the geometry of the bootsector Fabiano Rosas
2023-10-18 14:07 ` [PATCH v3 09/11] tests/qtest/migration: Set q35 as the default machine for x86_86 Fabiano Rosas
2023-10-18 14:07 ` [PATCH v3 10/11] tests/qtest/migration: Support more than one QEMU binary Fabiano Rosas
2023-10-18 14:25 ` Juan Quintela
2023-10-18 14:36 ` Fabiano Rosas
2023-10-18 14:45 ` Juan Quintela
2023-10-18 18:43 ` Peter Xu
2023-10-18 14:07 ` [PATCH v3 11/11] tests/qtest: Don't print messages from query instances Fabiano Rosas
2023-10-18 14:19 ` [PATCH v3 00/11] tests/migration-test: Allow testing older machine types Fabiano Rosas
2023-10-18 14:35 ` Daniel P. Berrangé
2023-10-18 19:01 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il7481df.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).