From: Markus Armbruster <armbru@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
qemu-trivial@nongnu.org
Subject: Re: [PATCH] hw/virtio/virtio-pci: Avoid compiler warning with -Wshadow
Date: Wed, 04 Oct 2023 13:33:36 +0200 [thread overview]
Message-ID: <87il7mfwq7.fsf@pond.sub.org> (raw)
In-Reply-To: <c3e2e15d-f4dd-a5bd-eab7-f4db9f93626e@redhat.com> (Thomas Huth's message of "Wed, 4 Oct 2023 13:08:26 +0200")
Thomas Huth <thuth@redhat.com> writes:
> On 04/10/2023 12.58, Markus Armbruster wrote:
>> Thomas Huth <thuth@redhat.com> writes:
>>
>>> "len" is used as parameter of the function virtio_write_config()
>>> and as a local variable, so this causes a compiler warning
>>> when compiling with "-Wshadow" and can be confusing for the reader.
>>> Rename the local variable to "caplen" to avoid this problem.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
[...]
>> I see the same warning in virtio_read_config(). Care to patch that,
>> too?
>
> Patch is already on the list:
> https://lore.kernel.org/qemu-devel/20231004095302.99037-1-thuth@redhat.com/
Awesome, thanks!
prev parent reply other threads:[~2023-10-04 11:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 7:55 [PATCH] hw/virtio/virtio-pci: Avoid compiler warning with -Wshadow Thomas Huth
2023-10-04 8:00 ` Philippe Mathieu-Daudé
2023-10-04 8:25 ` Michael S. Tsirkin
2023-10-04 9:49 ` Thomas Huth
2023-10-04 10:42 ` Markus Armbruster
2023-10-04 10:58 ` Markus Armbruster
2023-10-04 11:08 ` Thomas Huth
2023-10-04 11:33 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il7mfwq7.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).