[PATCH for-8.2] dockerfiles: bump tricore cross compiler container to Debian 11

[PATCH for-8.2] dockerfiles: bump tricore cross compiler container to Debian 11

[Paolo Bonzini]

With the release of version 12 on June 10, 2023, Debian 10 is
not supported anymore.  Modify the cross compiler container to
build on a newer version.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/docker/dockerfiles/debian-tricore-cross.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/docker/dockerfiles/debian-tricore-cross.docker b/tests/docker/dockerfiles/debian-tricore-cross.docker
index 269bfa8d423..5bd1963fb55 100644
--- a/tests/docker/dockerfiles/debian-tricore-cross.docker
+++ b/tests/docker/dockerfiles/debian-tricore-cross.docker
@@ -9,7 +9,7 @@
 #
 # SPDX-License-Identifier: GPL-2.0-or-later
 #
-FROM docker.io/library/debian:buster-slim
+FROM docker.io/library/debian:11-slim
 
 MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org>
 
-- 
2.41.0

Re: [PATCH for-8.2] dockerfiles: bump tricore cross compiler container to Debian 11

[Alex Bennée]

Paolo Bonzini <pbonzini@redhat.com> writes:

> With the release of version 12 on June 10, 2023, Debian 10 is
> not supported anymore.  Modify the cross compiler container to
> build on a newer version.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/docker/dockerfiles/debian-tricore-cross.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/debian-tricore-cross.docker
> b/tests/docker/dockerfiles/debian-tricore-cross.docker
> index 269bfa8d423..5bd1963fb55 100644
> --- a/tests/docker/dockerfiles/debian-tricore-cross.docker
> +++ b/tests/docker/dockerfiles/debian-tricore-cross.docker
> @@ -9,7 +9,7 @@
>  #
>  # SPDX-License-Identifier: GPL-2.0-or-later
>  #
> -FROM docker.io/library/debian:buster-slim
> +FROM docker.io/library/debian:11-slim
>  
>  MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org>

Acked-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [PATCH for-8.2] dockerfiles: bump tricore cross compiler container to Debian 11

[Bastian Koppelmann]

On Wed, Aug 09, 2023 at 10:29:45AM +0200, Paolo Bonzini wrote:
> With the release of version 12 on June 10, 2023, Debian 10 is
> not supported anymore.  Modify the cross compiler container to
> build on a newer version.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/docker/dockerfiles/debian-tricore-cross.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/docker/dockerfiles/debian-tricore-cross.docker b/tests/docker/dockerfiles/debian-tricore-cross.docker
> index 269bfa8d423..5bd1963fb55 100644
> --- a/tests/docker/dockerfiles/debian-tricore-cross.docker
> +++ b/tests/docker/dockerfiles/debian-tricore-cross.docker
> @@ -9,7 +9,7 @@
>  #
>  # SPDX-License-Identifier: GPL-2.0-or-later
>  #
> -FROM docker.io/library/debian:buster-slim
> +FROM docker.io/library/debian:11-slim

I think it would be better to skip debian-11 and use 12 instead.

Cheers,
Bastian

Re: [PATCH for-8.2] dockerfiles: bump tricore cross compiler container to Debian 11

[Paolo Bonzini]

On Wed, Aug 9, 2023 at 3:53 PM Bastian Koppelmann
<kbastian@mail.uni-paderborn.de> wrote:
> > diff --git a/tests/docker/dockerfiles/debian-tricore-cross.docker b/tests/docker/dockerfiles/debian-tricore-cross.docker
> > index 269bfa8d423..5bd1963fb55 100644
> > --- a/tests/docker/dockerfiles/debian-tricore-cross.docker
> > +++ b/tests/docker/dockerfiles/debian-tricore-cross.docker
> > @@ -9,7 +9,7 @@
> >  #
> >  # SPDX-License-Identifier: GPL-2.0-or-later
> >  #
> > -FROM docker.io/library/debian:buster-slim
> > +FROM docker.io/library/debian:11-slim
>
> I think it would be better to skip debian-11 and use 12 instead.

I picked 11 in order to keep the container in sync with the
lcitool-generated dockerfiles. Once we switch lcitool from 11 to
12, it is easier to see what the changes are and replicate them in
debian-tricore-cross and friends.

lcitool support for Debian 12 has already landed, but usually we
try to keep the containers on the oldest supported release of a
distro, and that is currently Debian 11.

Paolo

Re: [PATCH for-8.2] dockerfiles: bump tricore cross compiler container to Debian 11

[Bastian Koppelmann]

On Wed, Aug 09, 2023 at 04:33:37PM +0200, Paolo Bonzini wrote:
> On Wed, Aug 9, 2023 at 3:53 PM Bastian Koppelmann
> <kbastian@mail.uni-paderborn.de> wrote:
> > > diff --git a/tests/docker/dockerfiles/debian-tricore-cross.docker b/tests/docker/dockerfiles/debian-tricore-cross.docker
> > > index 269bfa8d423..5bd1963fb55 100644
> > > --- a/tests/docker/dockerfiles/debian-tricore-cross.docker
> > > +++ b/tests/docker/dockerfiles/debian-tricore-cross.docker
> > > @@ -9,7 +9,7 @@
> > >  #
> > >  # SPDX-License-Identifier: GPL-2.0-or-later
> > >  #
> > > -FROM docker.io/library/debian:buster-slim
> > > +FROM docker.io/library/debian:11-slim
> >
> > I think it would be better to skip debian-11 and use 12 instead.
> 
> I picked 11 in order to keep the container in sync with the
> lcitool-generated dockerfiles. Once we switch lcitool from 11 to
> 12, it is easier to see what the changes are and replicate them in
> debian-tricore-cross and friends.
> 
> lcitool support for Debian 12 has already landed, but usually we
> try to keep the containers on the oldest supported release of a
> distro, and that is currently Debian 11.

Thanks for the explanation.

Acked-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>

Cheers,
Bastian

Re: [PATCH for-8.2] dockerfiles: bump tricore cross compiler container to Debian 11

[Philippe Mathieu-Daudé]

On 9/8/23 10:29, Paolo Bonzini wrote:
> With the release of version 12 on June 10, 2023, Debian 10 is
> not supported anymore.  Modify the cross compiler container to
> build on a newer version.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   tests/docker/dockerfiles/debian-tricore-cross.docker | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Philippe Mathieu-Daudé <philmd@linaro.org>