qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-devel@nongnu.org,  Ilya Leoshkevich <iii@linux.ibm.com>,
	qemu-block@nongnu.org,
	 Alex Williamson <alex.williamson@redhat.com>,
	Fam Zheng <fam@euphon.net>,  Eric Blake <eblake@redhat.com>,
	 "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	 Stefan Hajnoczi <stefanha@redhat.com>,
	 Halil Pasic <pasic@linux.ibm.com>,
	 David Hildenbrand <david@redhat.com>,
	 Thomas Huth <thuth@redhat.com>,
	 Eric Farman <farman@linux.ibm.com>,
	 qemu-s390x@nongnu.org,  John Snow <jsnow@redhat.com>,
	 Christian Borntraeger <borntraeger@linux.ibm.com>,
	Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH 2/3] migration: Remove unused res_compatible
Date: Tue, 14 Feb 2023 19:14:18 +0100	[thread overview]
Message-ID: <87ilg45d39.fsf@secure.mitica> (raw)
In-Reply-To: <c88e6eed-b8e4-56ca-2aa0-686ae2c0b133@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Tue, 14 Feb 2023 18:09:12 +0300")

Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:
> On 08.02.23 16:57, Juan Quintela wrote:
>>   {
>> -    uint64_t pend_pre, pend_compat, pend_post;
>> +    uint64_t pend_pre, pend_post;
>>       bool in_postcopy = s->state == MIGRATION_STATUS_POSTCOPY_ACTIVE;
>>   -    qemu_savevm_state_pending_estimate(&pend_pre, &pend_compat,
>> &pend_post);
>> -    uint64_t pending_size = pend_pre + pend_compat + pend_post;
>> +    qemu_savevm_state_pending_estimate(&pend_pre, &pend_post);
>> +    uint64_t pending_size = pend_pre + pend_post;
>
> Mixed declarations are "gnerally not allowed" by devel/style.rst.. Preexisting, but we may fix it now.

They are used left and right.
But you are right.  Instead to change my code, I have sent a proposal to
change devel/style.rst.

Discuss it there O:-)

> Anyway:
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

Thanks.



  reply	other threads:[~2023-02-14 18:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 13:57 [PATCH 0/3] Remove res_compatible parameter Juan Quintela
2023-02-08 13:57 ` [PATCH 1/3] migration: In case of postcopy, the memory ends in res_postcopy_only Juan Quintela
2023-02-09 17:36   ` Vladimir Sementsov-Ogievskiy
2023-02-09 18:10     ` Juan Quintela
2023-02-14 15:04       ` Vladimir Sementsov-Ogievskiy
2023-02-14 15:47         ` Juan Quintela
2023-02-15  9:08     ` Juan Quintela
2023-02-15 11:36       ` Vladimir Sementsov-Ogievskiy
2023-02-08 13:57 ` [PATCH 2/3] migration: Remove unused res_compatible Juan Quintela
2023-02-14 15:09   ` Vladimir Sementsov-Ogievskiy
2023-02-14 18:14     ` Juan Quintela [this message]
2023-02-08 13:57 ` [PATCH 3/3] migration: Remove _only suffix for res_postcopy/precopy Juan Quintela
2023-02-14 15:27   ` Vladimir Sementsov-Ogievskiy
2023-02-14 16:06     ` unsubscribe " McDowell, Jadon
2023-02-14 18:22     ` Juan Quintela
2023-02-14 18:32       ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilg45d39.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=fam@euphon.net \
    --cc=farman@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=jsnow@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).