From: Juan Quintela <quintela@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Fam Zheng" <fam@euphon.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, "Peter Xu" <peterx@redhat.com>,
"Laurent Vivier" <Laurent@vivier.eu>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Ani Sinha" <ani@anisinha.ca>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Eric Blake" <eblake@redhat.com>,
"Hannes Reinecke" <hare@suse.com>,
"Vikram Garhwal" <fnu.vikram@xilinx.com>,
qemu-block@nongnu.org,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Pavel Pisa" <pisa@cmp.felk.cvut.cz>,
"Alistair Francis" <alistair@alistair23.me>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Greg Kurz" <groug@kaod.org>,
qemu-arm@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Stafford Horne" <shorne@gmail.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Andrew Baumann" <Andrew.Baumann@microsoft.com>,
qemu-ppc@nongnu.org, "Igor Mammedov" <imammedo@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PULL 00/38] Migration 20220127 patches
Date: Mon, 31 Jan 2022 10:03:41 +0100 [thread overview]
Message-ID: <87ilu08efm.fsf@secure.mitica> (raw)
In-Reply-To: <CAFEAcA9O_nZz=4VSvh+rFE4cXepUEBeUui2WdawBjjos+pqOeg@mail.gmail.com> (Peter Maydell's message of "Fri, 28 Jan 2022 11:05:10 +0000")
Peter Maydell <peter.maydell@linaro.org> wrote:
> On Thu, 27 Jan 2022 at 15:06, Juan Quintela <quintela@redhat.com> wrote:
>>
>> The following changes since commit 48302d4eb628ff0bea4d7e92cbf6b726410eb4c3:
>>
>> Merge remote-tracking branch
>> 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20220126' into staging
>> (2022-01-26 10:59:50 +0000)
>>
>> are available in the Git repository at:
>>
>> https://gitlab.com/juan.quintela/qemu.git tags/migration-20220127-pull-request
>>
>> for you to fetch changes up to 4e29a822de430e8d0d8bf5c61aaff0561a713d84:
>>
>> migration: Move temp page setup and cleanup into separate functions (2022-01-27 13:37:55 +0100)
>>
>> ----------------------------------------------------------------
>> Migration Pull request
>>
>> Hi
>>
>> This pull request includes every patch ack'd on the list for migration. In no particular order:
>>
>> - ram_transferred_add() - (Edmondson)
>> - vmstate canary (dgilbert)
>> - minimum_version_id_old removal (peter maydell)
>> - postcopy cleanups (peter xu)
>> - more cleanups (Philippe)
>> - yet more cleanups (zheng)
>> - colo and cleanups (zhang)
>
> Hi; this fails because we hit this assert in the vmstate canary check
> on some of the CI jobs, for instance:
> https://gitlab.com/qemu-project/qemu/-/jobs/2024872142
> and also on the NetBSD VM in tests/vm.
I dropped them on my PULL request, but there is something fishy on
aarch64 for migration. It makes exactly zero sense to fail with this
patch. Or something is missing a VMSTATE_END that only happens on
aarch64.
I will take a look.
Later, Juan.
PD. As Dave said, the patch makes sense to drop because we need a new
libslirp before pushing for it.
prev parent reply other threads:[~2022-01-31 9:07 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 15:05 [PULL 00/38] Migration 20220127 patches Juan Quintela
2022-01-27 15:05 ` [PULL 01/38] migration: All this fields are unsigned Juan Quintela
2022-01-27 15:05 ` [PULL 02/38] migration: We only need last_stage in two places Juan Quintela
2022-01-27 15:05 ` [PULL 03/38] migration: ram_release_pages() always receive 1 page as argument Juan Quintela
2022-01-27 15:05 ` [PULL 04/38] migration: Remove masking for compression Juan Quintela
2022-01-27 15:05 ` [PULL 05/38] migration: simplify do_compress_ram_page Juan Quintela
2022-01-27 15:05 ` [PULL 06/38] migration: Move ram_release_pages() call to save_zero_page_to_file() Juan Quintela
2022-01-27 15:05 ` [PULL 07/38] multifd: Use proper maximum compression values Juan Quintela
2022-01-27 15:05 ` [PULL 08/38] multifd: Move iov from pages to params Juan Quintela
2022-01-27 15:05 ` [PULL 09/38] multifd: Make zlib use iov's Juan Quintela
2022-01-27 15:05 ` [PULL 10/38] multifd: Make zstd " Juan Quintela
2022-01-27 15:05 ` [PULL 11/38] multifd: Remove send_write() method Juan Quintela
2022-01-27 15:05 ` [PULL 12/38] multifd: Use a single writev on the send side Juan Quintela
2022-01-27 15:05 ` [PULL 13/38] multifd: Unfold "used" variable by its value Juan Quintela
2022-01-27 15:05 ` [PULL 14/38] multifd: Use normal pages array on the send side Juan Quintela
2022-01-27 15:05 ` [PULL 15/38] multifd: Use normal pages array on the recv side Juan Quintela
2022-01-27 15:05 ` [PULL 16/38] multifd: recv side only needs the RAMBlock host address Juan Quintela
2022-01-27 15:05 ` [PULL 17/38] multifd: Rename pages_used to normal_pages Juan Quintela
2022-01-27 15:05 ` [PULL 18/38] Remove unnecessary minimum_version_id_old fields Juan Quintela
2022-02-15 17:13 ` Peter Maydell
2022-02-15 17:34 ` Cédric Le Goater
2022-02-15 17:59 ` Peter Maydell
2022-01-27 15:05 ` [PULL 19/38] migration/migration.c: Add missed default error handler for migration state Juan Quintela
2022-01-27 15:05 ` [PULL 20/38] migration/migration.c: Avoid COLO boot in postcopy migration Juan Quintela
2022-01-27 15:05 ` [PULL 21/38] migration/migration.c: Remove the MIGRATION_STATUS_ACTIVE when migration finished Juan Quintela
2022-01-27 15:05 ` [PULL 22/38] migration: Report the error returned when save_live_iterate fails Juan Quintela
2022-01-27 15:05 ` [PULL 23/38] migration: Add canary to VMSTATE_END_OF_LIST Juan Quintela
2022-01-27 15:05 ` [PULL 24/38] migration: Perform vmsd structure check during tests Juan Quintela
2022-01-27 15:05 ` [PULL 25/38] migration/ram: clean up unused comment Juan Quintela
2022-01-27 15:05 ` [PULL 26/38] migration: Drop dead code of ram_debug_dump_bitmap() Juan Quintela
2022-01-27 15:05 ` [PULL 27/38] migration: Don't return for postcopy_chunk_hostpages() Juan Quintela
2022-01-27 15:05 ` [PULL 28/38] migration: Drop postcopy_chunk_hostpages() Juan Quintela
2022-01-27 15:05 ` [PULL 29/38] migration: Do chunk page in postcopy_each_ram_send_discard() Juan Quintela
2022-01-27 15:05 ` [PULL 30/38] migration: Drop return code for disgard ram process Juan Quintela
2022-01-27 15:05 ` [PULL 31/38] migration: Don't return for postcopy_send_discard_bm_ram() Juan Quintela
2022-01-27 15:05 ` [PULL 32/38] migration: Introduce ram_transferred_add() Juan Quintela
2022-01-27 15:05 ` [PULL 33/38] migration: Tally pre-copy, downtime and post-copy bytes independently Juan Quintela
2022-01-27 15:05 ` [PULL 34/38] migration: No off-by-one for pss->page update in host page size Juan Quintela
2022-01-27 15:05 ` [PULL 35/38] migration: Enable UFFD_FEATURE_THREAD_ID even without blocktime feat Juan Quintela
2022-01-27 15:05 ` [PULL 36/38] migration: Add postcopy_has_request() Juan Quintela
2022-01-27 15:05 ` [PULL 37/38] migration: Simplify unqueue_page() Juan Quintela
2022-01-27 15:05 ` [PULL 38/38] migration: Move temp page setup and cleanup into separate functions Juan Quintela
2022-01-28 11:05 ` [PULL 00/38] Migration 20220127 patches Peter Maydell
2022-01-31 9:03 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilu08efm.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=Andrew.Baumann@microsoft.com \
--cc=Laurent@vivier.eu \
--cc=alistair@alistair23.me \
--cc=ani@anisinha.ca \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=fnu.vikram@xilinx.com \
--cc=groug@kaod.org \
--cc=hare@suse.com \
--cc=imammedo@redhat.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=pisa@cmp.felk.cvut.cz \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).