From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5D15C433EF for ; Mon, 31 Jan 2022 09:07:20 +0000 (UTC) Received: from localhost ([::1]:43974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nESed-0006o5-Gn for qemu-devel@archiver.kernel.org; Mon, 31 Jan 2022 04:07:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34946) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nESbL-0004pK-14 for qemu-devel@nongnu.org; Mon, 31 Jan 2022 04:03:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:52236) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nESbH-0003fH-1W for qemu-devel@nongnu.org; Mon, 31 Jan 2022 04:03:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643619825; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=/tJNqqyd7R10N2YzyaNOpnCH3qAZTzi0reSjbfLddrU=; b=R3lUFG+sAAslcEFnJZArbMuf0135hkwOab+4uoHY5eZkU4NG0HPVv9SLqpkpe12EotfnVt 3KBgVgC1Xu9L+KBJXPs8k83yovN301ioiNhaiLYbIAUug0biENyOTJAg8pHlcVtIBNWAmt 81f514RkqyV4mPwHZXfuBK8UL/LTED4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-219-Jn8vg6nYOxaHLX5A-VDPRQ-1; Mon, 31 Jan 2022 04:03:44 -0500 X-MC-Unique: Jn8vg6nYOxaHLX5A-VDPRQ-1 Received: by mail-wr1-f72.google.com with SMTP id r27-20020adfb1db000000b001d7567e33baso4516171wra.12 for ; Mon, 31 Jan 2022 01:03:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:reply-to:date:message-id:mime-version; bh=/tJNqqyd7R10N2YzyaNOpnCH3qAZTzi0reSjbfLddrU=; b=0Y7z7+8MbJpsiNtYFTkPdj8ZPJQnqR5c6ytpfvIgPMBTPj5FViWmK8pj+J0HcOpiwS n7DB+69RYmbQJ1oh567ko0BWMOFv6IGUdMCwG8Lt8DGUkx87HsYUkIAJd0wJHzsB37ib aUa5r1plyGjm870DV5GJYjvvdNPdS+dzR67jUJSXB88u+QcUwzp1xxNdpJfnvGnUoJqW tmIwned+Kb2L0DX0BmnaXohfV9KUIcTbZswtWHXfTzvkIEnrJ5iSoB43DE/49FhspmsA 8B/JtKOEnkEVMQKi/UaGbDQn0P5ay8R2Uu8mhKcF8v2GbK9ApGZJJ5Z5WHHdDge5WAmg h0hA== X-Gm-Message-State: AOAM5305AipRyTZeKp5NvoG0vIXxgQKq7sshqu7KWM6zVVErAOhuOYVI 2YwO+LlHDgjLWZn6LmfSjFNi5wRHlx3uk3o3tZlLzrtQ0GoqP7tjILX1sibRqkdIlTySppO/KjO WIxiDGWooim3ihls= X-Received: by 2002:a5d:4d50:: with SMTP id a16mr16826521wru.182.1643619822822; Mon, 31 Jan 2022 01:03:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJw19bQ7zGkfuAFBr4ljXoSOmEEYeHpwThFFGclhTpT3mHwa8Bfrfmwcvw4k9jPe5HBi1Bl4NQ== X-Received: by 2002:a5d:4d50:: with SMTP id a16mr16826480wru.182.1643619822599; Mon, 31 Jan 2022 01:03:42 -0800 (PST) Received: from localhost ([47.61.17.76]) by smtp.gmail.com with ESMTPSA id i6sm8410343wma.22.2022.01.31.01.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 01:03:42 -0800 (PST) From: Juan Quintela To: Peter Maydell Subject: Re: [PULL 00/38] Migration 20220127 patches In-Reply-To: (Peter Maydell's message of "Fri, 28 Jan 2022 11:05:10 +0000") References: <20220127150548.20595-1-quintela@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Date: Mon, 31 Jan 2022 10:03:41 +0100 Message-ID: <87ilu08efm.fsf@secure.mitica> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=quintela@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.129.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.088, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: Fam Zheng , "Michael S. Tsirkin" , Jason Wang , Mark Cave-Ayland , qemu-devel@nongnu.org, Peter Xu , Laurent Vivier , Gerd Hoffmann , Ani Sinha , "Edgar E. Iglesias" , Eric Blake , Hannes Reinecke , Vikram Garhwal , qemu-block@nongnu.org, Daniel Henrique Barboza , Markus Armbruster , Artyom Tarasenko , Pavel Pisa , Alistair Francis , "Dr. David Alan Gilbert" , Greg Kurz , qemu-arm@nongnu.org, =?utf-8?Q?C=C3=A9dric?= Le Goater , Paolo Bonzini , Stafford Horne , David Gibson , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Andrew Baumann , qemu-ppc@nongnu.org, Igor Mammedov , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Peter Maydell wrote: > On Thu, 27 Jan 2022 at 15:06, Juan Quintela wrote: >> >> The following changes since commit 48302d4eb628ff0bea4d7e92cbf6b726410eb4c3: >> >> Merge remote-tracking branch >> 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20220126' into staging >> (2022-01-26 10:59:50 +0000) >> >> are available in the Git repository at: >> >> https://gitlab.com/juan.quintela/qemu.git tags/migration-20220127-pull-request >> >> for you to fetch changes up to 4e29a822de430e8d0d8bf5c61aaff0561a713d84: >> >> migration: Move temp page setup and cleanup into separate functions (2022-01-27 13:37:55 +0100) >> >> ---------------------------------------------------------------- >> Migration Pull request >> >> Hi >> >> This pull request includes every patch ack'd on the list for migration. In no particular order: >> >> - ram_transferred_add() - (Edmondson) >> - vmstate canary (dgilbert) >> - minimum_version_id_old removal (peter maydell) >> - postcopy cleanups (peter xu) >> - more cleanups (Philippe) >> - yet more cleanups (zheng) >> - colo and cleanups (zhang) > > Hi; this fails because we hit this assert in the vmstate canary check > on some of the CI jobs, for instance: > https://gitlab.com/qemu-project/qemu/-/jobs/2024872142 > and also on the NetBSD VM in tests/vm. I dropped them on my PULL request, but there is something fishy on aarch64 for migration. It makes exactly zero sense to fail with this patch. Or something is missing a VMSTATE_END that only happens on aarch64. I will take a look. Later, Juan. PD. As Dave said, the patch makes sense to drop because we need a new libslirp before pushing for it.