* [PATCH 07/12] vnc: Remove the superfluous break
@ 2020-07-13 9:04 Yi Wang
2020-07-13 9:35 ` Thomas Huth
2020-07-13 10:02 ` Juan Quintela
0 siblings, 2 replies; 4+ messages in thread
From: Yi Wang @ 2020-07-13 9:04 UTC (permalink / raw)
To: qemu-devel; +Cc: wang.yi59, Liao Pingfang, wang.liang82, xue.zhihong
From: Liao Pingfang <liao.pingfang@zte.com.cn>
Remove the superfluous break, as there is a "return" before.
Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>a
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
ui/vnc-enc-tight.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 1e08518..cebd358 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -1125,7 +1125,6 @@ static int send_palette_rect(VncState *vs, int x, int y,
}
default:
return -1; /* No palette for 8bits colors */
- break;
}
bytes = w * h;
vs->tight->tight.offset = bytes;
--
2.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 07/12] vnc: Remove the superfluous break
2020-07-13 9:04 [PATCH 07/12] vnc: Remove the superfluous break Yi Wang
@ 2020-07-13 9:35 ` Thomas Huth
2020-09-01 6:37 ` Laurent Vivier
2020-07-13 10:02 ` Juan Quintela
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Huth @ 2020-07-13 9:35 UTC (permalink / raw)
To: Yi Wang, qemu-devel
Cc: xue.zhihong, QEMU Trivial, wang.liang82, Liao Pingfang,
Gerd Hoffmann
On 13/07/2020 11.04, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove the superfluous break, as there is a "return" before.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>a
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> ui/vnc-enc-tight.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
> index 1e08518..cebd358 100644
> --- a/ui/vnc-enc-tight.c
> +++ b/ui/vnc-enc-tight.c
> @@ -1125,7 +1125,6 @@ static int send_palette_rect(VncState *vs, int x, int y,
> }
> default:
> return -1; /* No palette for 8bits colors */
> - break;
> }
> bytes = w * h;
> vs->tight->tight.offset = bytes;
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 07/12] vnc: Remove the superfluous break
2020-07-13 9:04 [PATCH 07/12] vnc: Remove the superfluous break Yi Wang
2020-07-13 9:35 ` Thomas Huth
@ 2020-07-13 10:02 ` Juan Quintela
1 sibling, 0 replies; 4+ messages in thread
From: Juan Quintela @ 2020-07-13 10:02 UTC (permalink / raw)
To: Yi Wang; +Cc: xue.zhihong, wang.liang82, qemu-devel, Liao Pingfang
Yi Wang <wang.yi59@zte.com.cn> wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove the superfluous break, as there is a "return" before.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>a
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 07/12] vnc: Remove the superfluous break
2020-07-13 9:35 ` Thomas Huth
@ 2020-09-01 6:37 ` Laurent Vivier
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2020-09-01 6:37 UTC (permalink / raw)
To: Thomas Huth, Yi Wang, qemu-devel
Cc: QEMU Trivial, Liao Pingfang, wang.liang82, xue.zhihong,
Gerd Hoffmann
Le 13/07/2020 à 11:35, Thomas Huth a écrit :
> On 13/07/2020 11.04, Yi Wang wrote:
>> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>>
>> Remove the superfluous break, as there is a "return" before.
>>
>> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>a
>> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> ui/vnc-enc-tight.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
>> index 1e08518..cebd358 100644
>> --- a/ui/vnc-enc-tight.c
>> +++ b/ui/vnc-enc-tight.c
>> @@ -1125,7 +1125,6 @@ static int send_palette_rect(VncState *vs, int x, int y,
>> }
>> default:
>> return -1; /* No palette for 8bits colors */
>> - break;
>> }
>> bytes = w * h;
>> vs->tight->tight.offset = bytes;
>>
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-01 6:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-13 9:04 [PATCH 07/12] vnc: Remove the superfluous break Yi Wang
2020-07-13 9:35 ` Thomas Huth
2020-09-01 6:37 ` Laurent Vivier
2020-07-13 10:02 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).