From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWgOD-0005yp-Ts for qemu-devel@nongnu.org; Sat, 23 Jun 2018 07:07:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWgOA-0002MM-Nz for qemu-devel@nongnu.org; Sat, 23 Jun 2018 07:07:33 -0400 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:33637) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWgOA-0002M5-F6 for qemu-devel@nongnu.org; Sat, 23 Jun 2018 07:07:30 -0400 Received: by mail-wm0-x230.google.com with SMTP id z6-v6so8313084wma.0 for ; Sat, 23 Jun 2018 04:07:30 -0700 (PDT) References: <20180621184116.910-1-alex.bennee@linaro.org> <87efgzur9n.fsf@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: Date: Sat, 23 Jun 2018 12:07:27 +0100 Message-ID: <87in692234.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] blogposts: add post about the new check-tcg infrastructure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov Cc: qemu-devel , Paolo Bonzini Max Filippov writes: > On Fri, Jun 22, 2018 at 2:03 AM, Alex Benn=C3=A9e wrote: >> >> Max Filippov writes: >> >>> On Thu, Jun 21, 2018 at 11:41 AM, Alex Benn=C3=A9e wrote: >>>> Signed-off-by: Alex Benn=C3=A9e >>>> --- >>>> _posts/2018-06-21-tcg-testing.md | 129 +++++++++++++++++++++++++++++++ >>>> 1 file changed, 129 insertions(+) >>>> create mode 100644 _posts/2018-06-21-tcg-testing.md >>>> >>>> diff --git a/_posts/2018-06-21-tcg-testing.md b/_posts/2018-06-21-tcg-= testing.md >>> >>> [...] >>> >>>> +The `tests/tcg` directory still contains a number of source files we >>>> +don't build. Notably the cris, lm32, mips, openrisc and xtensa target= s have >>>> +a set of tests that need a system emulator. Now we have the >>>> +infrastructure for compiling I hope we can get support for system >>>> +tests added fairly quickly. There will need to be some work to figure >>>> +out a nice common way to pass results back to the build-system. For >>>> +linux-user this is simple as all programs can simply return their exit >>>> +code however for system emulation this is a little more involved. >>> >>> xtensa tests pass exit codes to the build system through semihosting ca= lls. >>> If any of them fails make check fails as well. >> >> I've re-written that section as: >> >> The `tests/tcg` directory still contains a number of source files we >> don't build. >> >> The cris and openrisc directories contain user-space tests which just >> need the support of a toolchain and the relevant Makefile plumbing to >> be added. >> >> The lm32, mips and xtensa targets have a set of tests that need a >> system emulator. Aside from adding the compilers as docker images some >> additional work is needed to handle the differences between plain >> linux-user tests which can simply return an exit code to getting the >> results from a qemu-system emulation. Some architectures have >> semi-hosting support already for this while others report their test >> status over a simple serial link which will need to be parsed and >> handled in the `run-%:` test rule. >> >> How is that? > > 'run-%' goal is only present in xtensa Makefile, other test suites have > explicit loop in the 'check' goal. Otherwise LGTM. The TCG tests added a generic run-% rule: run-%: % $(call run-test, $<, $(QEMU) $<, "$< on $(TARGET_NAME)") Although individual tests can override it. > >> Any chance you could look into what it would take to package up the >> xtensa toolchain in a docker container? > > Can you point me to an example? Well this was the base attempt: https://github.com/stsquad/qemu/commit/daee9dc013b13b13e81f720176c5e379c05e= d0e0 So I guess we need to add the overlay to the image? > >> Are they simply tarballs of binaries? > > Yes, we have that option: > > https://github.com/foss-xtensa/toolchain/releases > > Or they may be built from source. -- Alex Benn=C3=A9e