From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8q9v-0002eq-C4 for qemu-devel@nongnu.org; Thu, 11 May 2017 11:37:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8q9s-0001nJ-49 for qemu-devel@nongnu.org; Thu, 11 May 2017 11:37:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47182) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d8q9r-0001l0-Tm for qemu-devel@nongnu.org; Thu, 11 May 2017 11:37:40 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BF73B4E339 for ; Thu, 11 May 2017 15:37:38 +0000 (UTC) From: Juan Quintela In-Reply-To: <20170511152710.GI2078@work-vm> (David Alan Gilbert's message of "Thu, 11 May 2017 16:27:11 +0100") References: <20170511143901.6340-1-quintela@redhat.com> <149451627681.336.14543368400046903247@c05f1edc8ed1> <20170511152710.GI2078@work-vm> Reply-To: quintela@redhat.com Date: Thu, 11 May 2017 17:37:37 +0200 Message-ID: <87inl7h0am.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] migration: Move check_migratable() into qdev.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: lvivier@redhat.com, peterx@redhat.com, qemu-devel@nongnu.org "Dr. David Alan Gilbert" wrote: > * no-reply@patchew.org (no-reply@patchew.org) wrote: >> Hi, >> >> CC armeb-linux-user/gdbstub-xml.o >> CC armeb-linux-user/trace/generated-helpers.o >> LINK armeb-linux-user/qemu-armeb >> ../hw/core/qdev.o: In function `check_only_migratable': >> /var/tmp/patchew-tester-tmp-uf2ealih/src/hw/core/qdev.c:869: >> undefined reference to `only_migratable' >> collect2: error: ld returned 1 exit status >> Makefile:201: recipe for target 'qemu-armeb' failed >> make[1]: *** [qemu-armeb] Error 1 >> Makefile:327: recipe for target 'subdir-armeb-linux-user' failed >> make: *** [subdir-armeb-linux-user] Error 2 >> === OUTPUT END === > > Right, you see why I suggested testing for the user only build! grrrr, ok, thanks. So trivial change, what could have failed ... > > Dave > >> >> Test command exited with code: 2 >> >> >> --- >> Email generated automatically by Patchew [http://patchew.org/]. >> Please send your feedback to patchew-devel@freelists.org > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK