From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brkcj-0003hg-RW for qemu-devel@nongnu.org; Wed, 05 Oct 2016 07:44:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brkcf-0007zi-Mh for qemu-devel@nongnu.org; Wed, 05 Oct 2016 07:44:32 -0400 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:37865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brkce-0007zG-UU for qemu-devel@nongnu.org; Wed, 05 Oct 2016 07:44:29 -0400 Received: by mail-wm0-x234.google.com with SMTP id b201so204014897wmb.0 for ; Wed, 05 Oct 2016 04:44:28 -0700 (PDT) References: <1474048017-26696-1-git-send-email-rth@twiddle.net> <1474048017-26696-15-git-send-email-rth@twiddle.net> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1474048017-26696-15-git-send-email-rth@twiddle.net> Date: Wed, 05 Oct 2016 12:44:25 +0100 Message-ID: <87int7rpeu.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v4 14/35] tcg: Add atomic128 helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org Richard Henderson writes: > Force the use of cmpxchg16b on x86_64. > > Wikipedia suggests that only very old AMD64 (circa 2004) did not have > this instruction. Further, it's required by Windows 8 so no new cpus > will ever omit it. > > If we truely care about these, then we could check this at startup time > and then avoid executing paths that use it. > > Signed-off-by: Richard Henderson > diff --git a/tcg-runtime.c b/tcg-runtime.c > index aa55d12..0c97cdf 100644 > --- a/tcg-runtime.c > +++ b/tcg-runtime.c > @@ -118,8 +118,8 @@ static void *atomic_mmu_lookup(CPUArchState *env, target_ulong addr, > /* Macro to call the above, with local variables from the use context. */ > #define ATOMIC_MMU_LOOKUP atomic_mmu_lookup(env, addr, DATA_SIZE, GETPC()) > > -#define ATOMIC_NAME(X) HELPER(glue(glue(atomic_ ## X, SUFFIX), END)) > #define EXTRA_ARGS > +#define ATOMIC_NAME(X) HELPER(glue(glue(atomic_ ## X, SUFFIX), END)) This seems a null change. I think it was also in the last series. -- Alex Bennée