From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a99IO-0008Tb-AT for qemu-devel@nongnu.org; Wed, 16 Dec 2015 05:26:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a99IK-0004ru-7q for qemu-devel@nongnu.org; Wed, 16 Dec 2015 05:26:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a99IK-0004rl-2X for qemu-devel@nongnu.org; Wed, 16 Dec 2015 05:26:52 -0500 From: Juan Quintela In-Reply-To: <1450206170-26901-3-git-send-email-dgilbert@redhat.com> (David Alan Gilbert's message of "Tue, 15 Dec 2015 19:02:46 +0000") References: <1450206170-26901-1-git-send-email-dgilbert@redhat.com> <1450206170-26901-3-git-send-email-dgilbert@redhat.com> Date: Wed, 16 Dec 2015 11:26:42 +0100 Message-ID: <87io3ywuxp.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/6] migration: Add state records for migration incoming Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: amit.shah@redhat.com, jdenemar@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com "Dr. David Alan Gilbert (git)" wrote: > From: zhanghailiang > > For migration destination, we also need to know its state, > we will use it in COLO. > > Here we add a new member 'state' for MigrationIncomingState, > and also use migrate_set_state() to modify its value. > > Signed-off-by: zhanghailiang > > dgilbert: Fixed early free of MigraitonIncomingState > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Forget comment to previous patch. Improving the comment, and saying that it allows to also work on IncomingState instead of "Fix" could help.