From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37592)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1YTlD0-00085N-0x
	for qemu-devel@nongnu.org; Fri, 06 Mar 2015 00:54:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1YTlCw-0001Ry-RR
	for qemu-devel@nongnu.org; Fri, 06 Mar 2015 00:54:01 -0500
Received: from e23smtp01.au.ibm.com ([202.81.31.143]:59035)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1YTlCw-0001RI-4A
	for qemu-devel@nongnu.org; Fri, 06 Mar 2015 00:53:58 -0500
Received: from /spool/local
	by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aneesh.kumar@linux.vnet.ibm.com>;
	Fri, 6 Mar 2015 15:53:54 +1000
Received: from d23relay09.au.ibm.com (d23relay09.au.ibm.com [9.185.63.181])
	by d23dlp02.au.ibm.com (Postfix) with ESMTP id F11322BB004D
	for <qemu-devel@nongnu.org>; Fri,  6 Mar 2015 16:53:49 +1100 (EST)
Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])
	by d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
	t265reKk43253976
	for <qemu-devel@nongnu.org>; Fri, 6 Mar 2015 16:53:49 +1100
Received: from d23av01.au.ibm.com (localhost [127.0.0.1])
	by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	t265rFOs029552
	for <qemu-devel@nongnu.org>; Fri, 6 Mar 2015 16:53:15 +1100
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
In-Reply-To: <54F7786F.2020409@msgid.tls.msk.ru>
References: <54F7786F.2020409@msgid.tls.msk.ru>
Date: Fri, 06 Mar 2015 11:22:56 +0530
Message-ID: <87ioeesmdj.fsf@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] 9pfs-proxy: -retval vs errno vs -1
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel <qemu-devel@nongnu.org>, Anthony Liguori <aliguori@amazon.com>

Michael Tokarev <mjt@tls.msk.ru> writes:

> Another interesting tidbit is in hw/9pfs/virtio-9p-proxy.c.
>
> All filesystem methods use common v9fs_request() function,
> which returns -errno.  So far so good.
>
> Now, *all* places which call this function, does this:
>
>     retval = v9fs_request(...);
>     if (retval < 0) {
>         errno = -retval;
>     }
>     return retval;
>
> and *some* does this:
>
>     retval = v9fs_request(...);
>     if (retval < 0) {
>         errno = -retval;
>         retval = -1;
>     }
>     return retval;

We should be able to drop that retval = -1;

-aneesh