From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDCbp-0004CE-Oc for qemu-devel@nongnu.org; Tue, 11 Feb 2014 07:38:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDCbk-0007Iw-Op for qemu-devel@nongnu.org; Tue, 11 Feb 2014 07:38:41 -0500 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:47004 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDCbk-0007Ik-Jp for qemu-devel@nongnu.org; Tue, 11 Feb 2014 07:38:36 -0500 References: <153a8e98437c7d4b7fc3df2bf375fbc9e0bdb8ef.1392101145.git.peter.crosthwaite@xilinx.com> <20140211095528.GA2509@work-vm> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20140211095528.GA2509@work-vm> Date: Tue, 11 Feb 2014 12:38:33 +0000 Message-ID: <87ioslhliu.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptynesscheckk List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: peter.maydell@linaro.org, Peter Crosthwaite , mjt@tls.msk.ru, qemu-devel@nongnu.org, edgari@xilinx.com, mkletzan@redhat.com Dr. David Alan Gilbert writes: > * Peter Crosthwaite (peter.crosthwaite@xilinx.com) wrote: >> This was guarding against a full fifo rather than an empty fifo when >> popping. Fix. >> >> Signed-off-by: Peter Crosthwaite >> --- > > Reviewed-by: Dr. David Alan Gilbert > > I think this brings it back to how it was on the old FIFO code. This does make me wonder why it was changed? Was there another crashing case it fixed? -- Alex Bennée