[Qemu-devel] [PULL] pci: add pci test device

[Qemu-devel] [PULL] pci: add pci test device

[Michael S. Tsirkin]

The following changes since commit e2ec3f976803b360c70d9ae2ba13852fa5d11665:

  qjson: to_json() case QTYPE_QSTRING is buggy, rewrite (2013-04-13 19:40:25 +0000)

are available in the git repository at:

  git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony

for you to fetch changes up to efd70cb42aadca7e5cfe0fa037ef527d458bb3b5:

  pci: add pci test device (2013-04-14 14:12:24 +0300)

----------------------------------------------------------------
pci: add pci test device

This adds a new device that we can use for testing PCI PIO and MMIO, with and
without ioeventfd in different configurations.  FAST_MMIO will be added if/when
kvm supports it.  Also included are minor cleanups in kvm APIs that it needs.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

----------------------------------------------------------------
Michael S. Tsirkin (4):
      kvm: remove unused APIs
      kvm: support any size for pio eventfd
      kvm: support non datamatch ioeventfd
      pci: add pci test device

 default-configs/pci.mak    |   1 +
 docs/specs/pci-testdev.txt |  26 ++++
 hw/misc/Makefile.objs      |   1 +
 hw/misc/pci-testdev.c      | 306 +++++++++++++++++++++++++++++++++++++++++++++
 include/hw/pci/pci.h       |   1 +
 include/sysemu/kvm.h       |   4 -
 kvm-all.c                  | 133 ++++++++++----------
 kvm-stub.c                 |  10 --
 8 files changed, 403 insertions(+), 79 deletions(-)
 create mode 100644 docs/specs/pci-testdev.txt
 create mode 100644 hw/misc/pci-testdev.c

Re: [Qemu-devel] [PULL] pci: add pci test device

[Anthony Liguori]

"Michael S. Tsirkin" <mst@redhat.com> writes:

> The following changes since commit e2ec3f976803b360c70d9ae2ba13852fa5d11665:
>
>   qjson: to_json() case QTYPE_QSTRING is buggy, rewrite (2013-04-13 19:40:25 +0000)
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony
>
> for you to fetch changes up to efd70cb42aadca7e5cfe0fa037ef527d458bb3b5:
>
>   pci: add pci test device (2013-04-14 14:12:24 +0300)
>
> ----------------------------------------------------------------
> pci: add pci test device
>
> This adds a new device that we can use for testing PCI PIO and MMIO, with and
> without ioeventfd in different configurations.  FAST_MMIO will be added if/when
> kvm supports it.  Also included are minor cleanups in kvm APIs that it needs.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

I haven't commented before but I will now.  Please post patches along
with pull requests.

I noticed that the last patch does not include a copyright/license so
you'll need to respin anyway.

Regards,

Anthony Liguori

>
> ----------------------------------------------------------------
> Michael S. Tsirkin (4):
>       kvm: remove unused APIs
>       kvm: support any size for pio eventfd
>       kvm: support non datamatch ioeventfd
>       pci: add pci test device
>
>  default-configs/pci.mak    |   1 +
>  docs/specs/pci-testdev.txt |  26 ++++
>  hw/misc/Makefile.objs      |   1 +
>  hw/misc/pci-testdev.c      | 306 +++++++++++++++++++++++++++++++++++++++++++++
>  include/hw/pci/pci.h       |   1 +
>  include/sysemu/kvm.h       |   4 -
>  kvm-all.c                  | 133 ++++++++++----------
>  kvm-stub.c                 |  10 --
>  8 files changed, 403 insertions(+), 79 deletions(-)
>  create mode 100644 docs/specs/pci-testdev.txt
>  create mode 100644 hw/misc/pci-testdev.c

Re: [Qemu-devel] [PULL] pci: add pci test device

[Michael S. Tsirkin]

On Mon, Apr 15, 2013 at 07:28:58AM -0500, Anthony Liguori wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> 
> > The following changes since commit e2ec3f976803b360c70d9ae2ba13852fa5d11665:
> >
> >   qjson: to_json() case QTYPE_QSTRING is buggy, rewrite (2013-04-13 19:40:25 +0000)
> >
> > are available in the git repository at:
> >
> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony
> >
> > for you to fetch changes up to efd70cb42aadca7e5cfe0fa037ef527d458bb3b5:
> >
> >   pci: add pci test device (2013-04-14 14:12:24 +0300)
> >
> > ----------------------------------------------------------------
> > pci: add pci test device
> >
> > This adds a new device that we can use for testing PCI PIO and MMIO, with and
> > without ioeventfd in different configurations.  FAST_MMIO will be added if/when
> > kvm supports it.  Also included are minor cleanups in kvm APIs that it needs.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> I haven't commented before but I will now.  Please post patches along
> with pull requests.

Any ready flag in git that can do this?  I was using request-pull and
that does not attach patches, naturally. git-send-email also
does not seem to be able to handle merges which I sometimes
have.

Or do I have to write my own scripts for this?

Re: [Qemu-devel] [PULL] pci: add pci test device

[Anthony Liguori]

"Michael S. Tsirkin" <mst@redhat.com> writes:

> On Mon, Apr 15, 2013 at 07:28:58AM -0500, Anthony Liguori wrote:
>> "Michael S. Tsirkin" <mst@redhat.com> writes:
>> 
>> > The following changes since commit e2ec3f976803b360c70d9ae2ba13852fa5d11665:
>> >
>> >   qjson: to_json() case QTYPE_QSTRING is buggy, rewrite (2013-04-13 19:40:25 +0000)
>> >
>> > are available in the git repository at:
>> >
>> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony
>> >
>> > for you to fetch changes up to efd70cb42aadca7e5cfe0fa037ef527d458bb3b5:
>> >
>> >   pci: add pci test device (2013-04-14 14:12:24 +0300)
>> >
>> > ----------------------------------------------------------------
>> > pci: add pci test device
>> >
>> > This adds a new device that we can use for testing PCI PIO and MMIO, with and
>> > without ioeventfd in different configurations.  FAST_MMIO will be added if/when
>> > kvm supports it.  Also included are minor cleanups in kvm APIs that it needs.
>> >
>> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> 
>> I haven't commented before but I will now.  Please post patches along
>> with pull requests.
>
> Any ready flag in git that can do this?  I was using request-pull and
> that does not attach patches, naturally. git-send-email also
> does not seem to be able to handle merges which I sometimes
> have.
>
> Or do I have to write my own scripts for this?

Other folks have written scripts to automate this.  But essentially it's
just git format-patch -o staging/ origin/master, then git
request-pull to generate the cover letter,  then git-send-email
--subject-prefix='PULL'.

Regards,

Anthony Liguori