From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tm75r-0001ge-PV for qemu-devel@nongnu.org; Fri, 21 Dec 2012 13:13:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tm75l-0000o9-Dp for qemu-devel@nongnu.org; Fri, 21 Dec 2012 13:13:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tm75l-0000o2-6I for qemu-devel@nongnu.org; Fri, 21 Dec 2012 13:13:05 -0500 From: Juan Quintela In-Reply-To: <1355725509-5429-2-git-send-email-xiawenc@linux.vnet.ibm.com> (Wenchao Xia's message of "Mon, 17 Dec 2012 14:25:04 +0800") References: <1355725509-5429-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1355725509-5429-2-git-send-email-xiawenc@linux.vnet.ibm.com> Date: Fri, 21 Dec 2012 19:13:00 +0100 Message-ID: <87ip7vl1eb.fsf@elfo.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 1/6] snapshot: export function in block.c Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com Wenchao Xia wrote: > This patch moves bdrv_snapshotfind from savevm.c to block.c and export > it, also added bdrv_deappend in block.c. I think this patch can be splitted in two: - new bdv_deappend - move bdrv_snapshot_find