From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58967)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TIzxT-0003XU-Pa
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 06:44:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TIzxL-0006tn-A4
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 06:44:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:3054)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TIzxL-0006tb-2a
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 06:44:03 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q92Ai21o004642
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 2 Oct 2012 06:44:02 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <50616F38.1000201@redhat.com> (Paolo Bonzini's message of "Tue,
	25 Sep 2012 10:45:44 +0200")
References: <1348217255-22441-1-git-send-email-quintela@redhat.com>
	<1348217255-22441-3-git-send-email-quintela@redhat.com>
	<505C5AD0.1080903@redhat.com> <50616F38.1000201@redhat.com>
Date: Tue, 02 Oct 2012 12:43:59 +0200
Message-ID: <87ipat9ms0.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 02/41] fix migration sync
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 21/09/2012 14:17, Paolo Bonzini ha scritto:
>> 
>> -    QLIST_FOREACH(block, &ram_list.blocks, next) {
>> -        for (addr = 0; addr < block->length; addr += TARGET_PAGE_SIZE) {
>> -            if (!memory_region_get_dirty(block->mr, addr, TARGET_PAGE_SIZE,
>> -                                         DIRTY_MEMORY_MIGRATION)) {
>> -                memory_region_set_dirty(block->mr, addr, TARGET_PAGE_SIZE);
>> -            }
>> -        }
>> -    }
>> -
>>      memory_global_dirty_log_start();
>> +    memory_global_sync_dirty_bitmap(get_system_memory());

With the part of moving it after the memory_global_dirty_log_start() I
agree.

With the other suggestion, I will take another look at it.  The problem
is that vga code can also sync the kvm bitmap, and we want to get that
notifications also.

Later, Juan.