From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 0/9] build cleanups
Date: Tue, 25 Sep 2012 16:04:26 -0500 [thread overview]
Message-ID: <87ipb1yftx.fsf@codemonkey.ws> (raw)
In-Reply-To: <5059D903.1060500@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> Il 17/09/2012 18:44, Paolo Bonzini ha scritto:
>> Here are some cleanups to the build system, removing some unused files
>> from some of the products or fixing some strange behavior that bit me
>> while looking at the tree reorganization.
>>
>> Paolo
>>
>> Paolo Bonzini (9):
>> tools: split monitor-dummy.c, clean up qemu-tool.c
>> block: move QEMUIOVector functions to iov.c
>> build: avoid duplicate appearance of files
>> qemu-ga: do not include the QEMU main loop and dependencies
>> build: add object directory to QEMU_INCLUDES
>> build: add $(TARGET_DIR) to "GEN config-target.h" lines
>> build: use nesting magic for tools-obj-y
>> libcacard: add include/ to CFLAGS
>> libcacard: remove dependency on QEMU main loop
>>
>> Makefile | 9 ++---
>> Makefile.objs | 19 +++++++---
>> cutils.c | 103 ----------------------------------------------------
>> iov.c | 104 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>> libcacard/Makefile | 2 +-
>> monitor-dummy.c | 64 +++++++++++++++++++++++++++++++++
>> qemu-tool.c | 54 ----------------------------
>> rules.mak | 5 ++-
>> 8 file modificati, 189 inserzioni(+), 171 rimozioni(-)
>> create mode 100644 monitor-dummy.c
>>
>
> Doesn't apply anymore. :(
FWIW, it breaks make check too:
LINK tests/check-qdict
iohandler.o: In function `qemu_init_child_watch':
/home/anthony/git/qemu/iohandler.c:172: undefined reference to `qemu_bh_new'
iohandler.o: In function `sigchld_handler':
/home/anthony/git/qemu/iohandler.c:154: undefined reference to `qemu_bh_schedule'
main-loop.o: In function `main_loop_wait':
/home/anthony/git/qemu/main-loop.c:506: undefined reference to `qemu_bh_poll'
/home/anthony/git/qemu/main-loop.c:481: undefined reference to `qemu_bh_update_timeout'
collect2: ld returned 1 exit status
make: *** [tests/check-qdict] Error 1
Regards,
Anthony Liguori
>
> Paolo
prev parent reply other threads:[~2012-09-25 21:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 16:44 [Qemu-devel] [PATCH 0/9] build cleanups Paolo Bonzini
2012-09-17 16:44 ` [Qemu-devel] [PATCH 1/9] tools: split monitor-dummy.c, clean up qemu-tool.c Paolo Bonzini
2012-09-17 16:44 ` [Qemu-devel] [PATCH 2/9] block: move QEMUIOVector functions to iov.c Paolo Bonzini
2012-09-17 16:44 ` [Qemu-devel] [PATCH 3/9] build: avoid duplicate appearance of files Paolo Bonzini
2012-09-17 16:44 ` [Qemu-devel] [PATCH 4/9] qemu-ga: do not include the QEMU main loop and dependencies Paolo Bonzini
2012-09-17 16:44 ` [Qemu-devel] [PATCH 5/9] build: add object directory to QEMU_INCLUDES Paolo Bonzini
2012-09-17 16:45 ` [Qemu-devel] [PATCH 6/9] build: add $(TARGET_DIR) to "GEN config-target.h" lines Paolo Bonzini
2012-09-17 16:45 ` [Qemu-devel] [PATCH 7/9] build: use nesting magic for tools-obj-y Paolo Bonzini
2012-09-17 16:45 ` [Qemu-devel] [PATCH 8/9] libcacard: add include/ to CFLAGS Paolo Bonzini
2012-09-17 16:45 ` [Qemu-devel] [PATCH 9/9] libcacard: remove dependency on QEMU main loop Paolo Bonzini
2012-09-19 14:38 ` [Qemu-devel] [PATCH 0/9] build cleanups Paolo Bonzini
2012-09-25 21:04 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ipb1yftx.fsf@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).