From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGcIy-0002Yb-IA for qemu-devel@nongnu.org; Tue, 25 Sep 2012 17:04:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGcIx-0005Uy-DX for qemu-devel@nongnu.org; Tue, 25 Sep 2012 17:04:32 -0400 Received: from mail-oa0-f45.google.com ([209.85.219.45]:49404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGcIx-0005Ut-8Q for qemu-devel@nongnu.org; Tue, 25 Sep 2012 17:04:31 -0400 Received: by oagi18 with SMTP id i18so2331850oag.4 for ; Tue, 25 Sep 2012 14:04:30 -0700 (PDT) From: Anthony Liguori In-Reply-To: <5059D903.1060500@redhat.com> References: <1347900303-24314-1-git-send-email-pbonzini@redhat.com> <5059D903.1060500@redhat.com> Date: Tue, 25 Sep 2012 16:04:26 -0500 Message-ID: <87ipb1yftx.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 0/9] build cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel Paolo Bonzini writes: > Il 17/09/2012 18:44, Paolo Bonzini ha scritto: >> Here are some cleanups to the build system, removing some unused files >> from some of the products or fixing some strange behavior that bit me >> while looking at the tree reorganization. >> >> Paolo >> >> Paolo Bonzini (9): >> tools: split monitor-dummy.c, clean up qemu-tool.c >> block: move QEMUIOVector functions to iov.c >> build: avoid duplicate appearance of files >> qemu-ga: do not include the QEMU main loop and dependencies >> build: add object directory to QEMU_INCLUDES >> build: add $(TARGET_DIR) to "GEN config-target.h" lines >> build: use nesting magic for tools-obj-y >> libcacard: add include/ to CFLAGS >> libcacard: remove dependency on QEMU main loop >> >> Makefile | 9 ++--- >> Makefile.objs | 19 +++++++--- >> cutils.c | 103 ---------------------------------------------------- >> iov.c | 104 +++++++++++++++++++++++++++++++++++++++++++++++++++++ >> libcacard/Makefile | 2 +- >> monitor-dummy.c | 64 +++++++++++++++++++++++++++++++++ >> qemu-tool.c | 54 ---------------------------- >> rules.mak | 5 ++- >> 8 file modificati, 189 inserzioni(+), 171 rimozioni(-) >> create mode 100644 monitor-dummy.c >> > > Doesn't apply anymore. :( FWIW, it breaks make check too: LINK tests/check-qdict iohandler.o: In function `qemu_init_child_watch': /home/anthony/git/qemu/iohandler.c:172: undefined reference to `qemu_bh_new' iohandler.o: In function `sigchld_handler': /home/anthony/git/qemu/iohandler.c:154: undefined reference to `qemu_bh_schedule' main-loop.o: In function `main_loop_wait': /home/anthony/git/qemu/main-loop.c:506: undefined reference to `qemu_bh_poll' /home/anthony/git/qemu/main-loop.c:481: undefined reference to `qemu_bh_update_timeout' collect2: ld returned 1 exit status make: *** [tests/check-qdict] Error 1 Regards, Anthony Liguori > > Paolo