From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1N4Q-00075h-DK for qemu-devel@nongnu.org; Tue, 14 Aug 2012 15:46:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1N4P-00058S-30 for qemu-devel@nongnu.org; Tue, 14 Aug 2012 15:46:30 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:46296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1N4O-00055p-St for qemu-devel@nongnu.org; Tue, 14 Aug 2012 15:46:29 -0400 Received: from /spool/local by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 14 Aug 2012 13:46:11 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 16EA819D8036 for ; Tue, 14 Aug 2012 13:46:03 -0600 (MDT) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7EJjYs6015240 for ; Tue, 14 Aug 2012 13:45:35 -0600 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7EJjNY9011086 for ; Tue, 14 Aug 2012 13:45:23 -0600 From: Anthony Liguori In-Reply-To: <20120814114940.68c296c7@doriath.home> References: <1344951151-26387-1-git-send-email-aliguori@us.ibm.com> <20120814114940.68c296c7@doriath.home> Date: Tue, 14 Aug 2012 14:45:17 -0500 Message-ID: <87ipcls1f6.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] block-migration: deprecate block migration for the 1.2 release List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Kevin Wolf , Paolo Bonzini , qemu-devel@nongnu.org, Stefan Hajnoczi Luiz Capitulino writes: > On Tue, 14 Aug 2012 08:32:31 -0500 > Anthony Liguori wrote: > >> To be replaced with live block copy. >> >> Signed-off-by: Anthony Liguori >> --- >> migration.c | 9 +++++++++ >> 1 files changed, 9 insertions(+), 0 deletions(-) >> >> diff --git a/migration.c b/migration.c >> index 653a3c1..babccf4 100644 >> --- a/migration.c >> +++ b/migration.c >> @@ -482,10 +482,19 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk, >> MigrationParams params; >> const char *p; >> int ret; >> + static bool suppress_deprecation_message; >> >> params.blk = blk; >> params.shared = inc; >> >> + if (blk && !suppress_deprecation_message) { >> + qerror_report(ERROR_CLASS_GENERIC_ERROR, >> + "Block migration is deprecated. " >> + "See http://wiki.qemu.org/Features/LiveBlockCopy " >> + "for an alternative syntax."); > > Why not error_set()? Because we fall through (we don't fail). This is just a warning. If you error_set(), then the migration command fails. We don't want it to fail. I guess qerror_report will do that too :-( I'll change it to an fprintf :-(( Regards, Anthony Liguori > >> + suppress_deprecation_message = true; >> + } >> + >> if (s->state == MIG_STATE_ACTIVE) { >> error_set(errp, QERR_MIGRATION_ACTIVE); >> return;