From: anthony@codemonkey.ws
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: [Qemu-devel] Plan for error handling in QMP
Date: Thu, 26 Jul 2012 13:22:15 -0500 [thread overview]
Message-ID: <87ipdacrhj.fsf@codemonkey.ws> (raw)
Hi,
We had a violent^Wheated discussion on IRC about how to move forward
with Luiz's proposed error series. I think we reached consensus. This
note attempts to outline that.
Principles
----------
1. Errors should be free formed strings with a class code
2. There should be a small number of class codes (10-15) added
strictly when there are specific users of a code.
3. The class code should be expressed as an enum data type in the normal
QMP schema. Other than this, errors should have no structure in the
schema.[*]
4. We should drop all dictionary arguments in the current error
mechanisms beyond 'class' and 'desc'.
5. The following errors are used by libvirt:
- CommandNotFound: QMP parsing
- DeviceNotActive/KVMMissingCap: ballooning
- DeviceNotFound: drive_del
- MigrationExpected: cont
6. We need to make sure that these errors are preserved while other
errors should be consolidated.
- We need to state very clear for 1.2 which errors are going away.
7. We need to make sure that anything we expose in 1.2 stays that way.
If we're dropping 'InvalidParameterType' as a class code, it should be
dropped in 1.2. This could be achieved by making all existing codes
except for those in (5) report 'UnknownError' or something.[*]
[*] I took a little bit of license with these. Hopefully it's not
controversial.
Regards,
Anthony Liguori
next reply other threads:[~2012-07-26 18:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 18:22 anthony [this message]
2012-07-26 18:43 ` [Qemu-devel] Plan for error handling in QMP Luiz Capitulino
2012-07-26 18:47 ` Luiz Capitulino
2012-07-26 21:08 ` Anthony Liguori
2012-07-26 21:14 ` Luiz Capitulino
2012-07-26 22:47 ` Anthony Liguori
2012-07-27 14:24 ` Luiz Capitulino
2012-07-26 20:41 ` Eric Blake
2012-07-27 7:08 ` Paolo Bonzini
2012-07-26 21:16 ` Richard W.M. Jones
2012-07-27 7:08 ` Markus Armbruster
2012-07-27 7:11 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ipdacrhj.fsf@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).