Re: [Qemu-devel] [PATCH 23/36] arm: save always 32 fpu registers

[Juan Quintela <quintela@redhat.com>]

Peter Maydell <peter.maydell@linaro.org> wrote:
> On 19 March 2012 22:57, Juan Quintela <quintela@redhat.com> wrote:
>> This way, we fix a bug (we were overwritten the 16 first registers on
>> load), and we don't need to check for ARM_FEATUR_VPF3, we always send
>> the 32 registers.
>
> This commit message is out of date -- the overwriting bug was
> fixed in commit 15180256 last year. Possibly the patch should
> be dropped from your series? (If not, "ARM_FEATURE_VFP3".)

Reason for the change is not to have to write partial arrays.
Current code is doing

if ARM_FEATURE_VFP
  send first 16 registers
  if (ARM_FEATURE_VFP3
    send second 16 registers

I change it to:

if ARM_FEATURE_VFP
   send 32 registers

Notice that:
a- there is always 32 registers
b- makes the migration format the same for VFP and VFP3
c- we are already incompatible with previous versions, so this is not a
problem.

Normally, the less different options that we have on the migration
format, the easy to make sense of it.  It was not related to the bug
that we used to have in this area.

Later, Juan.