From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:34513)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1RG1wv-00044K-If
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 01:10:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1RG1wu-0007F4-E3
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 01:10:49 -0400
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
In-Reply-To: <1318879259-3052-1-git-send-email-sw@weilnetz.de>
References: <1318879259-3052-1-git-send-email-sw@weilnetz.de>
Date: Tue, 18 Oct 2011 10:40:39 +0530
Message-ID: <87ipnm7uls.fsf@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH] hw/9pfs: Fix missing parentheses
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org

On Mon, 17 Oct 2011 21:20:59 +0200, Stefan Weil <sw@weilnetz.de> wrote:
> cppcheck report:
> hw/9pfs/virtio-9p.c:2385:
>  style: Boolean result is used in bitwise operation.
>  Clarify expression with parentheses
> hw/9pfs/virtio-9p.c:2531:
>  style: Boolean result is used in bitwise operation.
>  Clarify expression with parentheses
> 
> Cc: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  hw/9pfs/virtio-9p.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
> index c01c31a..df0b22a 100644
> --- a/hw/9pfs/virtio-9p.c
> +++ b/hw/9pfs/virtio-9p.c
> @@ -2382,7 +2382,7 @@ static void v9fs_remove(void *opaque)
>          goto out_nofid;
>      }
>      /* if fs driver is not path based, return EOPNOTSUPP */
> -    if (!pdu->s->ctx.flags & PATHNAME_FSCONTEXT) {
> +    if (!(pdu->s->ctx.flags & PATHNAME_FSCONTEXT)) {
>          err = -EOPNOTSUPP;
>          goto out_err;
>      }
> @@ -2528,7 +2528,7 @@ static void v9fs_rename(void *opaque)
>      }
>      BUG_ON(fidp->fid_type != P9_FID_NONE);
>      /* if fs driver is not path based, return EOPNOTSUPP */
> -    if (!pdu->s->ctx.flags & PATHNAME_FSCONTEXT) {
> +    if (!(pdu->s->ctx.flags & PATHNAME_FSCONTEXT)) {
>          err = -EOPNOTSUPP;
>          goto out;
>      }

This is fixed in the new pull request i sent.

http://article.gmane.org/gmane.comp.emulators.qemu/120990
http://repo.or.cz/w/qemu/v9fs.git/commitdiff/c98f1d4a8bb6f779313043d2490093451cf52065?hp=7cca27dfde6435a7846d88e8a1fa927d0ab99919

-aneesh