From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15C6FCCF2D3 for ; Mon, 19 Oct 2026 08:09:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xIiQh-0002li-1z; Mon, 19 Oct 2026 04:09:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xIiQZ-0002fr-Fl for qemu-devel@nongnu.org; Mon, 19 Oct 2026 04:09:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xIiQX-0004Iz-KH for qemu-devel@nongnu.org; Mon, 19 Oct 2026 04:09:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792397340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-message-id:in-reply-to:in-reply-to: references:references; bh=9YUfwYqe6KLoYZjW2wWSXKj8ZV76DX6TpAPyYqYwhe8=; b=UNpH/Tc/arX9xSvHgmxHWCyJpN9yc7EsZSqFpByWBZnXQGQQMe2Su7jUSlU4oF20oozsOL 4Fr22hTKFU3G4gVzt7XTwh1Qn/naq9ERZQli3SRsvxvxYaL7CR67iWJ6qC6O6CIatnJQS6 +BkRIhAHPMj6Wk7KhX5DSy8f9/SLHxg= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-602-n_tiRJwNNgazkRIzb2Z2Gw-1; Mon, 19 Oct 2026 08:08:56 +0000 X-MC-Unique: n_tiRJwNNgazkRIzb2Z2Gw-1 X-Mimecast-MFC-AGG-ID: n_tiRJwNNgazkRIzb2Z2Gw_1792397333 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 95FF018001E6; Mon, 19 Oct 2026 08:08:52 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B10471955E70; Mon, 19 Oct 2026 08:08:50 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id DC3D421E6A04; Mon, 19 Oct 2026 10:08:47 +0200 (CEST) Resent-To: 17746591750@163.com, graf@amazon.com, FangSheng.Huang@amd.com, michael.roth@amd.com, jamin_lin@aspeedtech.com, kane_chen@aspeedtech.com, steven_lee@aspeedtech.com, andrew@codeconstruct.com.au, palmer@dabbelt.com, foss@defmacro.it, sebastian.huber@embedded-brains.de, jiaxun.yang@flygoat.com, lizhijian@fujitsu.com, edgar.iglesias@gmail.com, jasowangio@gmail.com, leetroy@gmail.com, liwei1518@gmail.com, npiggin@gmail.com, zhangckid@gmail.com, titusr@google.com, wuhaotsh@google.com, arei.gonglei@huawei.com, berto@igalia.com, zhao1.liu@intel.com, its@irrelevant.dk, joel@jms.id.au, clg@kaod.org, conor@kernel.org, david@kernel.org, jic23@kernel.org, kbusch@kernel.org, sstabellini@kernel.org, peter.maydell@linaro.org, richard.henderson@linaro.org, lixianglai@loongson.cn, zhiwei_liu@linux.alibaba.com, maobibo@loongson.cn, zhenwei.pi@linux.dev, qemu-arm@nongnu.org, adityag@linux.ibm.com, qemu-block@nongnu.org, amachhiw@linux.ibm.com, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, kfting@nuvoton.com, den@openvz.org, daniel.barboza@oss.qualcomm.com, philmd@oss.qualcomm.com, pierrick.bouvier@oss.qualcomm.com, chao.liu@processmission.com, sam@rfc1149.net, kvm@vger.kernel.org, linux-cxl@vger.kernel.org, alistair.francis@wdc.com, anthony@xenproject.org, borntraeger@linux.ibm.com, brueckner@linux.ibm.com, farman@linux.ibm.com, harshpb@linux.ibm.com, iii@linux.ibm.com, jjherne@linux.ibm.com, milesg@linux.ibm.com, mjrosato@linux.ibm.com, pasic@linux.ibm.com, rathc@linux.ibm.com, xen-devel@lists.xenproject.org, luc@lmichel.fr Resent-From: Markus Armbruster Resent-Date: Mon, 19 Oct 2026 10:08:47 +0200 Resent-Message-ID: <87v76y159s.fsf@pond.sub.org> From: Markus Armbruster To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Michael Roth , Pierrick Bouvier , Philippe =?utf-8?Q?Mathieu-Daud?= =?utf-8?Q?=C3=A9?= , Amit Machhiwal , Alexander Graf , Richard Henderson , "Gonglei (Arei)" , zhenwei pi , David Hildenbrand , Igor Mammedov , Alberto Garcia , Kevin Wolf , Hanna Reitz , "Michael S. Tsirkin" , Ani Sinha , Peter Maydell , Luc Michel , Zhao Liu , Jonathan Cameron , =?utf-8?Q?C=C3=A9dric?= Le Goater , Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley , Samuel Tardieu , Marcelo Tosatti , John Snow , "Denis V. Lunev" , Song Gao <17746591750@163.com>, Bibo Mao , Xianglai Li , Jiaxun Yang , FangSheng Huang , Tyrone Ting , Hao Wu , Jason Wang , Keith Busch , Klaus Jensen , Jesper Devantier , Nicholas Piggin , Aditya Gupta , Glenn Miles , Harsh Prateek Bora , Conor Dooley , Sebastian Huber , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Chao Liu , Halil Pasic , Christian Borntraeger , Jason Herne , Cornelia Huck , Eric Farman , Matthew Rosato , Ilya Leoshkevich , Titus Rwantare , Stefano Stabellini , Anthony PERARD , "Edgar E. Iglesias" , Zhang Chen , Li Zhijian , Peter Xu , Chinmay Rath , Hendrik Brueckner , kvm@vger.kernel.org, qemu-block@nongnu.org, qemu-arm@nongnu.org, linux-cxl@vger.kernel.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v5 35/62] qom: convert scalar properties to QAPI-aware registration In-Reply-To: <20260911-qom-qapi-v5-35-7732a55b7760@redhat.com> (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Fri, 11 Sep 2026 20:35:09 +0400") References: <20260911-qom-qapi-v5-0-7732a55b7760@redhat.com> <20260911-qom-qapi-v5-35-7732a55b7760@redhat.com> Date: Mon, 19 Oct 2026 09:41:59 +0200 Message-ID: <87jyne2l2w.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.34, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Marc-Andr=C3=A9 Lureau writes: > Reviewed-by: Amit Machhiwal > Signed-off-by: Marc-Andr=C3=A9 Lureau [...] > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 872920b6482b..4e5d8d9f86e3 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -4258,7 +4258,7 @@ static void virt_machine_class_init(ObjectClass *oc= , const void *data) > "Set on/off to enable/disable = high " > "memory region for PCI MMIO"); >=20=20 > - object_class_property_add(oc, "highmem-mmio-size", "size", > + object_class_property_add_qapi(oc, "highmem-mmio-size", &size_type_i= nfo, > virt_get_highmem_mmio_size, > virt_set_highmem_mmio_size, > NULL, NULL); > @@ -4266,7 +4266,7 @@ static void virt_machine_class_init(ObjectClass *oc= , const void *data) > "Set the high memory region si= ze " > "for PCI MMIO"); >=20=20 > - object_class_property_add(oc, "virtio-mmio-transports", "uint8", > + object_class_property_add_qapi(oc, "virtio-mmio-transports", &uint8_= type_info, scripts/checkpatch.pl gripes WARNING: line over 80 characters Easy enough to avoid. Many more below. > virt_get_virtio_transports, > virt_set_virtio_transports, > NULL, NULL); [...]