Re: [RFC PATCH 1/8] tests: vhost-vdpa: add initial VDUSE-based vhost-vdpa tests

[Fabiano Rosas <farosas@suse.de>]

Eugenio Pérez <eperezma@redhat.com> writes:

> Based on vhost-user tests, the qos register itself as a VDUSE device and
> receives the events from QEMU.
>
> The test infrastructure creates a thread that acts as a VDUSE device,
> while the regular test thread is managing QEMU.
>
> This basic test just verify that the guest memory ring addresses are
> accessible, similar to the already existing test in vhost-user.
>
> This enables automated testing of vhost-vdpa code paths that previously
> required manual testing with real hardware.
>
> Changes from vhost-user test:
> * Automatic cleanup of many things.
> * Handle the vduse fd and timeout.
> * VDPA device cannot be removed before deleting QEMU, killing QEMU in
>   vhost_vdpa_test_cleanup.
> * Read in enable callbacks, and the actual test_read_guest_mem is just
>   waiting.
> * Add vhost_vdpa_thread to abstract fd monitoring
> * Use QemuMutex and QemuConf for scoped cleanup
>
> RFC: I'm not sure if this is the right place to add the tests in meson.
> Also, a few things are just with asserts() or g_spawn(), instead of
> more elegant code.
>
> Also, I don't know how to include the libvduse.a library as meson
> complains it's out of the tests/ directory, so I'm including the .c
> directly.  Ugly but it works.
>

The proper way should be the following. Unfortunately, you'll have to
rewrite some parts of the test as it currently accesses symbols internal
to the library.

-- >8 --
From ca4418e57a2de83b1fea49f589f2c27ba424039b Mon Sep 17 00:00:00 2001
From: Fabiano Rosas <farosas@suse.de>
Date: Wed, 25 Mar 2026 17:54:41 -0300
Subject: [PATCH] tmp

---
 tests/qtest/meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index 2b002ea1ce..d6cf0e25ad 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -348,6 +348,7 @@ if have_tools and have_vhost_user_blk_server
 endif
 if have_libvduse and have_vhost_vdpa
   qos_test_ss.add(files('vhost-vdpa-test.c'))
+  qos_test_ss.add(libvduse)
 endif
 
 tpmemu_files = ['tpm-emu.c', 'tpm-util.c', 'tpm-tests.c']
@@ -395,7 +396,8 @@ qtests = {
   'pxe-test': files('boot-sector.c'),
   'pnv-xive2-test': files('pnv-xive2-common.c', 'pnv-xive2-flush-sync.c',
                           'pnv-xive2-nvpg_bar.c'),
-  'qos-test': [chardev, io, qos_test_ss.apply({}).sources()],
+  'qos-test': [chardev, io, qos_test_ss.apply({}).sources(),
+               qos_test_ss.apply({}).dependencies()],
   'tpm-crb-swtpm-test': [io, tpmemu_files],
   'tpm-crb-test': [io, tpmemu_files],
   'tpm-tis-swtpm-test': [io, tpmemu_files, 'tpm-tis-util.c'],
-- 
2.51.0