From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yonggang Luo" <luoyonggang@gmail.com>
Subject: Re: [PATCH 4/4] gitlab: prevent duplicated meson log artifacts in test jobs
Date: Tue, 09 Sep 2025 09:46:34 +0100 [thread overview]
Message-ID: <87jz286mj9.fsf@draig.linaro.org> (raw)
In-Reply-To: <aL_QzBYYd4HB0T3Q@redhat.com> ("Daniel P. Berrangé"'s message of "Tue, 9 Sep 2025 08:04:30 +0100")
Daniel P. Berrangé <berrange@redhat.com> writes:
> On Mon, Sep 08, 2025 at 10:21:38PM +0100, Alex Bennée wrote:
>> Daniel P. Berrangé <berrange@redhat.com> writes:
>>
>> > The build jobs will populate build/meson-logs/ with various files
>> > that are added as artifacts.
>> >
>> > The test jobs preserve the state of the build jobs, so we must
>> > delete any pre-existing logs to prevent confusion from duplicate
>> > artifacts.
>>
>> Will this cause us to rebuild needlessly?
>
> These files aren't involved in any rebuild / stale checks &
> the test pipeline I ran show no difference in what was done.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
prev parent reply other threads:[~2025-09-09 8:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 19:08 [PATCH 0/4] gitlab: misc artifact / log handling fixes Daniel P. Berrangé
2025-09-08 19:08 ` [PATCH 1/4] gitlab: replace avocado results files with meson results files Daniel P. Berrangé
2025-09-08 21:20 ` Alex Bennée
2025-09-08 19:08 ` [PATCH 2/4] gitlab: always include entire of meson-logs directory Daniel P. Berrangé
2025-09-08 21:20 ` Alex Bennée
2025-09-08 19:09 ` [PATCH 3/4] gitlab: include all junit XML files from meson Daniel P. Berrangé
2025-09-08 21:20 ` Alex Bennée
2025-09-08 19:09 ` [PATCH 4/4] gitlab: prevent duplicated meson log artifacts in test jobs Daniel P. Berrangé
2025-09-08 21:21 ` Alex Bennée
2025-09-09 7:04 ` Daniel P. Berrangé
2025-09-09 8:46 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jz286mj9.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).