From: Fabiano Rosas <farosas@suse.de>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: "Prasad Pandit" <ppandit@redhat.com>,
"Maciej S . Szmigiero" <mail@maciej.szmigiero.name>,
"Cédric Le Goater" <clg@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
peterx@redhat.com, "Avihai Horon" <avihaih@nvidia.com>
Subject: Re: [PATCH v3 0/7] migration/multifd: Some VFIO / postcopy preparations on flush
Date: Tue, 17 Dec 2024 12:26:25 -0300 [thread overview]
Message-ID: <87jzbywcta.fsf@suse.de> (raw)
In-Reply-To: <20241206224755.1108686-1-peterx@redhat.com>
Peter Xu <peterx@redhat.com> writes:
> CI: https://gitlab.com/peterx/qemu/-/pipelines/1577280033
> (note: it's a pipeline of two patchsets, to save CI credits and time)
>
> v1: https://lore.kernel.org/r/20241205185303.897010-1-peterx@redhat.com
> v2: https://lore.kernel.org/r/20241206005834.1050905-1-peterx@redhat.com
>
> v3 changelog:
> - R-bs collected
> - Update commit message of patch 1 [Fabiano]
> - English updates [Fabiano]
> - Update comment for MULTIFD_SYNC_ALL [Fabiano]
> - In multifd_send_sync_main(), assert on req type [Fabiano]
> - Some more comments and cleanup for RAM_SAVE_FLAG_* movement [Fabiano]
> - Update the last document patch [Fabiano]
>
> This series provides some changes that may be helpful for either VFIO or
> postcopy integration on top of multifd.
>
> For VFIO, only patches 1 & 2 are relevant.
>
> For postcopy, it's about patches 3-7, but it needs to be based on 1+2
> because of a context dependency.
>
> All these patches can be seen as cleanups / slight optimizations on top of
> master branch with/without the VFIO/postcopy work.
>
> Besides CI, qtests, and some real-world multifd tests just to monitor the
> sync events happen all correct, I made sure to cover 7.2 machine type
> (which uses the legacy sync) so it still works as before - basically sync
> will be more frequent, but all thing keeps working smoothly so far.
>
> Thanks,
>
> Peter Xu (7):
> migration/multifd: Further remove the SYNC on complete
> migration/multifd: Allow to sync with sender threads only
> migration/ram: Move RAM_SAVE_FLAG* into ram.h
> migration/multifd: Unify RAM_SAVE_FLAG_MULTIFD_FLUSH messages
> migration/multifd: Remove sync processing on postcopy
> migration/multifd: Cleanup src flushes on condition check
> migration/multifd: Document the reason to sync for save_setup()
>
> migration/multifd.h | 27 ++++++++++--
> migration/ram.h | 28 ++++++++++++
> migration/rdma.h | 7 ---
> migration/multifd-nocomp.c | 74 ++++++++++++++++++++++++++++++-
> migration/multifd.c | 17 +++++---
> migration/ram.c | 89 +++++++++++++++++---------------------
> 6 files changed, 173 insertions(+), 69 deletions(-)
Queued, thanks!
prev parent reply other threads:[~2024-12-17 15:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 22:47 [PATCH v3 0/7] migration/multifd: Some VFIO / postcopy preparations on flush Peter Xu
2024-12-06 22:47 ` [PATCH v3 1/7] migration/multifd: Further remove the SYNC on complete Peter Xu
2024-12-06 22:47 ` [PATCH v3 2/7] migration/multifd: Allow to sync with sender threads only Peter Xu
2024-12-09 20:52 ` Fabiano Rosas
2024-12-06 22:47 ` [PATCH v3 3/7] migration/ram: Move RAM_SAVE_FLAG* into ram.h Peter Xu
2024-12-06 22:47 ` [PATCH v3 4/7] migration/multifd: Unify RAM_SAVE_FLAG_MULTIFD_FLUSH messages Peter Xu
2024-12-06 22:47 ` [PATCH v3 5/7] migration/multifd: Remove sync processing on postcopy Peter Xu
2024-12-06 22:47 ` [PATCH v3 6/7] migration/multifd: Cleanup src flushes on condition check Peter Xu
2024-12-09 20:55 ` Fabiano Rosas
2024-12-06 22:47 ` [PATCH v3 7/7] migration/multifd: Document the reason to sync for save_setup() Peter Xu
2024-12-09 20:56 ` Fabiano Rosas
2024-12-17 15:26 ` Fabiano Rosas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzbywcta.fsf@suse.de \
--to=farosas@suse.de \
--cc=alex.williamson@redhat.com \
--cc=avihaih@nvidia.com \
--cc=clg@redhat.com \
--cc=mail@maciej.szmigiero.name \
--cc=peterx@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).