From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99ACEC46CD2 for ; Tue, 2 Jan 2024 19:33:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rKkVJ-00038v-16; Tue, 02 Jan 2024 14:32:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rKkVH-00038i-QB for qemu-devel@nongnu.org; Tue, 02 Jan 2024 14:32:43 -0500 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rKkV9-0005Ks-BP for qemu-devel@nongnu.org; Tue, 02 Jan 2024 14:32:43 -0500 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A80BB21FDB; Tue, 2 Jan 2024 19:32:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704223953; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DWOzxwAF8UlO3mrdMv5cgm8lZHYSCc9gbUk5pVA1jrU=; b=W+9lmgNz0/B+fWb/ey0byG4JvgYzK8zX9jwSA74ns6MtxLMwpQbiOsiNYaMAvo0yNhXqLe V6Lf4MrZjKlTBVOOrZVpaJ9HaotrRJuXjMeV9mEiycN3xg2Ke/edURcVJcFpAGzL3dbzT9 HLiOeZ64PZ094zy02xzWKLZdqY44Lro= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704223953; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DWOzxwAF8UlO3mrdMv5cgm8lZHYSCc9gbUk5pVA1jrU=; b=Dq6UpOmHBWDwyZf9yyDK1oSMd6da222TiRsjOBcJUY8YmhbCwFKT1lRn7/I26LatPwxCoz gImbAhJRa2rOEBAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704223953; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DWOzxwAF8UlO3mrdMv5cgm8lZHYSCc9gbUk5pVA1jrU=; b=W+9lmgNz0/B+fWb/ey0byG4JvgYzK8zX9jwSA74ns6MtxLMwpQbiOsiNYaMAvo0yNhXqLe V6Lf4MrZjKlTBVOOrZVpaJ9HaotrRJuXjMeV9mEiycN3xg2Ke/edURcVJcFpAGzL3dbzT9 HLiOeZ64PZ094zy02xzWKLZdqY44Lro= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704223953; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DWOzxwAF8UlO3mrdMv5cgm8lZHYSCc9gbUk5pVA1jrU=; b=Dq6UpOmHBWDwyZf9yyDK1oSMd6da222TiRsjOBcJUY8YmhbCwFKT1lRn7/I26LatPwxCoz gImbAhJRa2rOEBAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D39D413AC6; Tue, 2 Jan 2024 19:32:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XsxMG9BklGUTLgAAD6G6ig (envelope-from ); Tue, 02 Jan 2024 19:32:32 +0000 From: Fabiano Rosas To: Avihai Horon , qemu-devel@nongnu.org Cc: Juan Quintela , Peter Xu , Leonardo Bras , Li Zhijian , Avihai Horon Subject: Re: [PATCH 07/11] migration/multifd: Fix leaking of Error in TLS error flow In-Reply-To: <20231231093016.14204-8-avihaih@nvidia.com> References: <20231231093016.14204-1-avihaih@nvidia.com> <20231231093016.14204-8-avihaih@nvidia.com> Date: Tue, 02 Jan 2024 16:32:29 -0300 Message-ID: <87jzor5y5u.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-2.64 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; BAYES_HAM(-2.33)[96.88%]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[7]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from] Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=W+9lmgNz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Dq6UpOmH X-Rspamd-Queue-Id: A80BB21FDB Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Avihai Horon writes: > If there is an error in multifd TLS handshake task, > multifd_tls_outgoing_handshake() retrieves the error with > qio_task_propagate_error() but never frees it. > > Fix it by freeing the obtained Error. > > In addition, the error is not reported at all, so report it with > migrate_set_error(). > > Fixes: 29647140157a ("migration/tls: add support for multifd tls-handshake") > Signed-off-by: Avihai Horon Reviewed-by: Fabiano Rosas