From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E732C61D94 for ; Tue, 21 Nov 2023 14:21:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r5Rd4-0008D4-P3; Tue, 21 Nov 2023 09:21:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5Rd1-0008Cp-S6 for qemu-devel@nongnu.org; Tue, 21 Nov 2023 09:21:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5Rcz-000363-IX for qemu-devel@nongnu.org; Tue, 21 Nov 2023 09:21:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700576484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9natOj4m62QyKPjklHYryPBQtpc+tVXCef9rDkajAhA=; b=aCyIcssRH7mCMyQTUFBrAi3nO6VTj9PSohiQ8HnRZCZwc7wQ/U57L+uSON3k5cR8d5YS5b 3h++WLaSUwoJmXw0tJb20IODN05SKoxPNfa1tRCR/lBceCTF8vQSsLqeQFRJSOi8BBtvVw QUBl7X401A7kW0bRdC9TfVHa6c6U9zo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-8_cWTpoEPmqqqXJ5WN4uxA-1; Tue, 21 Nov 2023 09:21:21 -0500 X-MC-Unique: 8_cWTpoEPmqqqXJ5WN4uxA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2D9E4812C27; Tue, 21 Nov 2023 14:21:20 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.148]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BA1D1121306; Tue, 21 Nov 2023 14:21:20 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id F30A921E6A1F; Tue, 21 Nov 2023 15:21:18 +0100 (CET) From: Markus Armbruster To: John Snow Cc: qemu-devel@nongnu.org, Peter Maydell , Michael Roth Subject: Re: [PATCH 08/19] qapi/schema: add static typing and assertions to lookup_type() References: <20231116014350.653792-1-jsnow@redhat.com> <20231116014350.653792-9-jsnow@redhat.com> Date: Tue, 21 Nov 2023 15:21:18 +0100 In-Reply-To: <20231116014350.653792-9-jsnow@redhat.com> (John Snow's message of "Wed, 15 Nov 2023 20:43:39 -0500") Message-ID: <87jzqb2nmp.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org John Snow writes: > This function is a bit hard to type as-is; mypy needs some assertions to > assist with the type narrowing. > > Signed-off-by: John Snow > --- > scripts/qapi/schema.py | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py > index a1094283828..3308f334872 100644 > --- a/scripts/qapi/schema.py > +++ b/scripts/qapi/schema.py > @@ -968,8 +968,12 @@ def lookup_entity(self, name, typ=None): > return None > return ent > > - def lookup_type(self, name): > - return self.lookup_entity(name, QAPISchemaType) > + def lookup_type(self, name: str) -> Optional[QAPISchemaType]: Any particular reason not to delay the type hints until PATCH 16? > + typ = self.lookup_entity(name, QAPISchemaType) > + if typ is None: > + return None > + assert isinstance(typ, QAPISchemaType) > + return typ Would typ = self.lookup_entity(name, QAPISchemaType) assert isinstance(typ, Optional[QAPISchemaType]) return typ work? > > def resolve_type(self, name, info, what): > typ = self.lookup_type(name)