From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A46FCDB482 for ; Wed, 18 Oct 2023 14:19:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qt7O9-0003Ku-Ca; Wed, 18 Oct 2023 10:19:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qt7O7-0003Hp-AM for qemu-devel@nongnu.org; Wed, 18 Oct 2023 10:19:07 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qt7O5-0005l7-ME for qemu-devel@nongnu.org; Wed, 18 Oct 2023 10:19:07 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EDC36219FC; Wed, 18 Oct 2023 14:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1697638743; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eve+LVLDsGlua1whAMWLlutUOrFmB0gs8yKqjeHJpAA=; b=rXJyS9lUzEkI0Uka897Fc5yLoLot+bA3w2IbhLRxhv+5hg8LBL1e0U1odwLWC/a/R3ZeHc aNYJIYfy3FjSg9cuTwXGRpJjQEVR/Xt0+7GGK/jwVR0XTgLIpPzzheTME7kMx1+MpIJmuP glVQ7ooQVTyG19S6Jwj1qVSODZVI4FI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1697638743; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eve+LVLDsGlua1whAMWLlutUOrFmB0gs8yKqjeHJpAA=; b=cVlc2VyHL6RjkfXn4qeeVLyD11T7wwAgJKEDpuIT6itFcdSHjsJClcWylj2nlstXhoH9a9 GAA+O7hnlZDrNDCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8004613915; Wed, 18 Oct 2023 14:19:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NKvvElfpL2XGUwAAMHmgww (envelope-from ); Wed, 18 Oct 2023 14:19:03 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Juan Quintela , Peter Xu , Leonardo Bras , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , =?utf-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Alex =?utf-8?Q?Benn=C3=A9e?= , Thomas Huth Subject: Re: [PATCH v3 00/11] tests/migration-test: Allow testing older machine types In-Reply-To: <20231018140736.3618-1-farosas@suse.de> References: <20231018140736.3618-1-farosas@suse.de> Date: Wed, 18 Oct 2023 11:19:01 -0300 Message-ID: <87jzrkdne2.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-6.00 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; BAYES_HAM(-1.90)[94.42%]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-3.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_SEVEN(0.00)[8]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] Received-SPF: pass client-ip=195.135.220.28; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Fabiano Rosas writes: > This adds support for running migration-test with two different QEMU > versions to test migration compatibility. The tests automatically > choose the latest machine type supported by both QEMU versions. Let me point out two situations that came up while developing this: 1) There was a generic command line change in QEMU (-audio option) introduced this cycle that was ported to the command line used by libqtest.c. This means that when using the same command line to start both guests, the older one will not recognize the option and will break. Ideally, we would keep command lines out of the library and require each test to provide their own. Then maybe the migration code could cope with the change somehow. 2) When fixing an issue during a release cycle, that issue can still show up on the next one when using this series to test compatibility. There's probably not much we can do here, but remember the issues that were already fixed and ignore them when they appear in these compatibiliy tests. I don't see how to avoid the situations above, but I think their existence implies we cannot enable by default any sort of migration compatibility testing that uses a live guest.