From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BC48E95A8F for ; Tue, 10 Oct 2023 10:11:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qq9h7-0002TG-4x; Tue, 10 Oct 2023 06:10:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qq9gv-0002Lj-Ia for qemu-devel@nongnu.org; Tue, 10 Oct 2023 06:10:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qq9go-0008Kb-Jk for qemu-devel@nongnu.org; Tue, 10 Oct 2023 06:10:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696932609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JYK0CQO/LOVSI69A9QSZD2Na+ty08FG/Z/mX+Fx+1ww=; b=VSn23Znj6ACeU7cUWX6mRyBQAU6m+kefIFOoQrGOaWhMWViG3UBxUZQ8/OvMiWdbgaYn7I XK2MrYdYP5f0/SOpooZaG+K8/psntZWFhT1kKTGP+9YvLrJfYxz9TpXd8iFDNNb/mtOT6s vrHVO965OPgJvQMyh/KagX/lJ8RXvvM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-221-C8mO9QFrOI6Wl7bGxvnHkQ-1; Tue, 10 Oct 2023 06:09:58 -0400 X-MC-Unique: C8mO9QFrOI6Wl7bGxvnHkQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B3357185A79C; Tue, 10 Oct 2023 10:09:57 +0000 (UTC) Received: from localhost (unknown [10.39.193.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5E8BD492B16; Tue, 10 Oct 2023 10:09:57 +0000 (UTC) From: Cornelia Huck To: Gavin Shan , Peter Maydell , Paolo Bonzini Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, kvm@vger.kernel.org Subject: Re: [PATCH for-8.2 2/2] arm/kvm: convert to kvm_get_one_reg In-Reply-To: <875y6565ll.fsf@redhat.com> Organization: "Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12, D-85630 Grasbrunn, Handelsregister: Amtsgericht =?utf-8?Q?M=C3=BCnchen=2C?= HRB 153243, =?utf-8?Q?Gesch=C3=A4ftsf=C3=BChrer=3A?= Ryan Barnhart, Charles Cachera, Michael O'Neill, Amy Ross" References: <20230718111404.23479-1-cohuck@redhat.com> <20230718111404.23479-3-cohuck@redhat.com> <878rb5g0f0.fsf@redhat.com> <4a990b57-800c-6799-8c23-4488069ffb76@redhat.com> <875y6565ll.fsf@redhat.com> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Date: Tue, 10 Oct 2023 12:09:54 +0200 Message-ID: <87jzrubxfx.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org [spooky season is coming up, so time for some thread necromancy!] On Thu, Jul 27 2023, Cornelia Huck wrote: > On Tue, Jul 25 2023, Gavin Shan wrote: > >> On 7/24/23 18:48, Cornelia Huck wrote: >>> On Mon, Jul 24 2023, Gavin Shan wrote: >>>> >>>> On 7/18/23 21:14, Cornelia Huck wrote: >>>>> We can neaten the code by switching the callers that work on a >>>>> CPUstate to the kvm_get_one_reg function. >>>>> >>>>> Signed-off-by: Cornelia Huck >>>>> --- >>>>> target/arm/kvm.c | 15 +++--------- >>>>> target/arm/kvm64.c | 57 ++++++++++++---------------------------------- >>>>> 2 files changed, 18 insertions(+), 54 deletions(-) >>>>> >>>> >>>> The replacements look good to me. However, I guess it's worty to apply >>>> the same replacements for target/arm/kvm64.c since we're here? >>>> >>>> [gshan@gshan arm]$ pwd >>>> /home/gshan/sandbox/q/target/arm >>>> [gshan@gshan arm]$ git grep KVM_GET_ONE_REG >>>> kvm64.c: err = ioctl(fd, KVM_GET_ONE_REG, &idreg); >>>> kvm64.c: return ioctl(fd, KVM_GET_ONE_REG, &idreg); >>>> kvm64.c: ret = ioctl(fdarray[2], KVM_GET_ONE_REG, ®); >>> >>> These are the callers that don't work on a CPUState (all in initial >>> feature discovery IIRC), so they need to stay that way. >>> >> >> Right, All these ioctl commands are issued when CPUState isn't around. However, there >> are two wrappers read_sys_{reg32, reg64}(). The ioctl call in kvm_arm_sve_get_vls() >> can be replaced by read_sys_reg64(). I guess it'd better to do this in a separate >> patch if you agree. > > Yes, we could do that, but I'm not sure how much it adds to the > code... in any case, I agree that this would be a separate patch. This series has managed to bubble up to the top of my todo list again, and I think I'll just go ahead and include that as a separate change on top.