From: Karim Taha <kariem.taha2.7@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH v3 22/23] bsd-user: Implement shmat(2) and shmdt(2)
Date: Thu, 14 Sep 2023 19:55:49 +0300 [thread overview]
Message-ID: <87jzss4ru2.fsf@gmail.com> (raw)
In-Reply-To: <0bdcfe70-58ac-4ed0-4f75-33d30653a9c2@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
Do I need to enclose `shmdt implmenetation` in a WITH_MMAP_LOCK_GUARD() block?
Mr.Warner forwared me a patch series ,that you sent on Sun 20 Aug,
for the linux-user, which encloses the implementation in such a block.
--
Karim Taha
> On 9/9/23 12:37, Karim Taha wrote:
>> +static inline abi_long do_bsd_shmdt(abi_ulong shmaddr)
>> +{
>> + int i;
>> +
>> + for (i = 0; i < N_BSD_SHM_REGIONS; ++i) {
>> + if (bsd_shm_regions[i].start == shmaddr) {
>> + bsd_shm_regions[i].start = 0;
>> + page_set_flags(shmaddr,
>> + shmaddr + bsd_shm_regions[i].size, 0);
>> + break;
>> + }
>> + }
>> +
>> + return get_errno(shmdt(g2h_untagged(shmaddr)));
>> +}
>
> On success, this needs to mmap_reserve the region for reserved_va.
>
>
> r~
next prev parent reply other threads:[~2023-09-14 16:57 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 19:36 [PATCH v3 00/23] bsd-user: Implement mmap related system calls for FreeBSD Karim Taha
2023-09-09 19:36 ` [PATCH v3 01/23] bsd-user: Implement struct target_ipc_perm Karim Taha
2023-09-09 19:36 ` [PATCH v3 02/23] bsd-user: Implement struct target_shmid_ds Karim Taha
2023-09-09 19:36 ` [PATCH v3 03/23] bsd-user: Declarations for ipc_perm and shmid_ds conversion functions Karim Taha
2023-09-09 19:36 ` [PATCH v3 04/23] bsd-user: Introduce freebsd/os-misc.h to the source tree Karim Taha
2023-09-09 19:36 ` [PATCH v3 05/23] bsd-user: Implement shm_open2(2) system call Karim Taha
2023-09-11 23:51 ` Richard Henderson
2023-09-09 19:36 ` [PATCH v3 06/23] bsd-user: Implement shm_rename(2) " Karim Taha
2023-09-09 19:36 ` [PATCH v3 07/23] bsd-user: Add bsd-mem.c to meson.build Karim Taha
2023-09-09 19:36 ` [PATCH v3 08/23] bsd-user: Implement target_set_brk function in bsd-mem.c instead of os-syscall.c Karim Taha
2023-09-09 19:36 ` [PATCH v3 09/23] bsd-user: Implement ipc_perm conversion between host and target Karim Taha
2023-09-09 19:36 ` [PATCH v3 10/23] bsd-user: Implement shmid_ds " Karim Taha
2023-09-11 23:53 ` Richard Henderson
2023-09-09 19:36 ` [PATCH v3 11/23] bsd-user: Introduce bsd-mem.h to the source tree Karim Taha
2023-09-09 19:36 ` [PATCH v3 12/23] bsd-user: Implement mmap(2) and munmap(2) Karim Taha
2023-09-09 19:36 ` [PATCH v3 13/23] bsd-user: Implement mprotect(2) Karim Taha
2023-09-09 19:36 ` [PATCH v3 14/23] bsd-user: Implement msync(2) Karim Taha
2023-09-09 19:36 ` [PATCH v3 15/23] bsd-user: Implement mlock(2), munlock(2), mlockall(2), munlockall(2), minherit(2) Karim Taha
2023-09-09 19:36 ` [PATCH v3 16/23] bsd-user: Implment madvise(2) to match the linux-user implementation Karim Taha
2023-09-11 23:56 ` Richard Henderson
2023-09-09 19:36 ` [PATCH v3 17/23] bsd-user: Implement mincore(2) Karim Taha
2023-09-12 0:03 ` Richard Henderson
2023-09-13 22:02 ` Karim Taha
2023-09-13 22:24 ` Richard Henderson
2023-09-09 19:36 ` [PATCH v3 18/23] bsd-user: Implement do_obreak function Karim Taha
2023-09-12 0:05 ` Richard Henderson
2023-09-09 19:37 ` [PATCH v3 19/23] bsd-user: Implement shm_open(2) Karim Taha
2023-09-12 0:06 ` Richard Henderson
2023-09-09 19:37 ` [PATCH v3 20/23] bsd-user: Implement shm_unlink(2) and shmget(2) Karim Taha
2023-09-09 19:37 ` [PATCH v3 21/23] bsd-user: Implement shmctl(2) Karim Taha
2023-09-13 13:01 ` Karim Taha
2023-09-13 15:33 ` Richard Henderson
2023-09-09 19:37 ` [PATCH v3 22/23] bsd-user: Implement shmat(2) and shmdt(2) Karim Taha
2023-09-12 0:08 ` Richard Henderson
2023-09-14 16:55 ` Karim Taha [this message]
2023-09-14 17:52 ` Richard Henderson
2023-09-09 19:37 ` [PATCH v3 23/23] bsd-user: Add stubs for vadvise(), sbrk() and sstk() Karim Taha
2023-09-12 0:09 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzss4ru2.fsf@gmail.com \
--to=kariem.taha2.7@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).