From: Keith Packard via <qemu-devel@nongnu.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH] target/m68k: Map FPU exceptions to FPSR register
Date: Wed, 02 Aug 2023 20:53:03 -0700 [thread overview]
Message-ID: <87jzucok80.fsf@keithp.com> (raw)
In-Reply-To: <13b823f2-ab77-3456-1c00-bc9b8880327a@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
> Good catch. Mostly ok.
Thanks much for looking at this.
> No need for inline markers.
Thanks.
> In general it is bad form to call HELPER(foo) directly. In this case
> it doesn't hurt, but better form to reverse the implementations.
Good point. I had copied this from the arm vfp code which flipped the
order. I've flipped those around.
> What's missing is an update to vmstate, to make sure all the architectural bits are
> properly saved. Add
Yup, thanks. I've sent another version of the patch along.
--
-keith
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2023-08-03 3:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 0:55 [PATCH] target/m68k: Map FPU exceptions to FPSR register Keith Packard via
2023-08-03 2:00 ` Richard Henderson
2023-08-03 3:53 ` Keith Packard via [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-03 3:52 Keith Packard via
2023-08-03 14:49 ` Richard Henderson
2023-10-03 21:19 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzucok80.fsf@keithp.com \
--to=qemu-devel@nongnu.org \
--cc=keithp@keithp.com \
--cc=laurent@vivier.eu \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).