From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98F1AC77B61 for ; Fri, 28 Apr 2023 12:11:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1psMwS-00060I-HF; Fri, 28 Apr 2023 08:11:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psMwK-0005zt-9R for qemu-devel@nongnu.org; Fri, 28 Apr 2023 08:11:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psMwF-0003be-As for qemu-devel@nongnu.org; Fri, 28 Apr 2023 08:11:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682683856; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=pucO7epSP7Q4ekItW88JrQNZgS7/+SLrdKMFrKO3e50=; b=hehe0/pQAismR0+jrysdAC6Rvr4tFvFtTFPL0TNBcQ2+rUknZLWafmUxQ/GfxqxT63PSOk PtX3cZjP8Cpdnuyyyi+C261teRXjgI+fl+0FgQh+tc1qFHmDm8SdECKDBlOjIkQiHzL5ot vJCjPjCCsyoSnu0C9h2CVrdV4TrKuO8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-34-UsY58S-PMemWjWwsHFWksQ-1; Fri, 28 Apr 2023 08:10:52 -0400 X-MC-Unique: UsY58S-PMemWjWwsHFWksQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f19517536eso32827515e9.2 for ; Fri, 28 Apr 2023 05:10:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682683850; x=1685275850; h=mime-version:message-id:date:reply-to:user-agent:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pucO7epSP7Q4ekItW88JrQNZgS7/+SLrdKMFrKO3e50=; b=ioAwsYP6ZhfJBTahwF1Ccz1vRmFi08usgNn4hftLxrvgfXxNUpBcuJpwWjh28IK8vd isKVwyF7KwLSgkrHV/xpvabaV+29mEBzSgc/UacEX+cfFiZEl7gRJkppuO/fAdAGGNWZ 1dpU4KnKzZ6fBk4MSOPxu77PHbVN1BKTIu119olyEuwUbXJHF304cCsufH3G/CawuWHn Q97Fi9f8uJTzdlNGu+HN05UkXvQI61NCMiHpPmAlQ19p2ITZB3c2R+bFwPxsrYsV8CZ2 Bi2qrrMKbQo4Fi9Z0K0IG6113kRbJ+X3ciEvYMZTRfLfJi/0FukFdzvw1C6tMNTOFR8Q dZdA== X-Gm-Message-State: AC+VfDzOiYiHGyER1fY481zP1RvAfIwjPl9UwuI+6SMSBqrtZjlMYOKZ Ytf+ziRywq3yx06UpgTQCouWi9Q/f/8+UjxJgeq+6EOwhdP75skcHk04Rr1aXC84Q59wWsvKZP8 5voyXMT7dTjn/tJA= X-Received: by 2002:a05:600c:24cd:b0:3f1:92e8:a6fe with SMTP id 13-20020a05600c24cd00b003f192e8a6femr3933633wmu.31.1682683850586; Fri, 28 Apr 2023 05:10:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7PwWPxoWSvBTR2NBjP750O2ouwxsOekKuWWg7o/IcJ6NKUPUbA+8uPocz4ZEplIKQDy6GqAg== X-Received: by 2002:a05:600c:24cd:b0:3f1:92e8:a6fe with SMTP id 13-20020a05600c24cd00b003f192e8a6femr3933611wmu.31.1682683850347; Fri, 28 Apr 2023 05:10:50 -0700 (PDT) Received: from redhat.com (static-213-163-6-89.ipcom.comunitel.net. [89.6.163.213]) by smtp.gmail.com with ESMTPSA id y21-20020a05600c365500b003f182a10106sm24298056wmq.8.2023.04.28.05.10.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 05:10:49 -0700 (PDT) From: Juan Quintela To: Lukas Straub Cc: qemu-devel , Peter Xu , Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: Re: [PATCH v2 06/13] ram.c: Call update_compress_thread_counts from compress_send_queued_data In-Reply-To: (Lukas Straub's message of "Thu, 20 Apr 2023 11:48:10 +0200") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Date: Fri, 28 Apr 2023 14:10:48 +0200 Message-ID: <87jzxwb41j.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=170.10.133.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.171, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Lukas Straub wrote: > This makes the core compress code more independend from ram.c. > > Signed-off-by: Lukas Straub Reviewed-by: Juan Quintela I haven't looked all the series yet > @@ -1575,15 +1577,8 @@ static void flush_compressed_data(RAMState *rs) > qemu_mutex_lock(&comp_param[idx].mutex); > if (!comp_param[idx].quit) { > CompressParam *param = &comp_param[idx]; > - len = send_queued_data(param); > + send_queued_data(param); but it appears that send_queued_data don't need to return anything now.