From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A630C433EF for ; Tue, 21 Dec 2021 16:13:53 +0000 (UTC) Received: from localhost ([::1]:57542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzhlw-0007mK-0P for qemu-devel@archiver.kernel.org; Tue, 21 Dec 2021 11:13:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzhkQ-000721-2K for qemu-devel@nongnu.org; Tue, 21 Dec 2021 11:12:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:28680) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzhkM-0002Fm-Ow for qemu-devel@nongnu.org; Tue, 21 Dec 2021 11:12:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640103132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KvVTVwi4MGaKrj4NRFiy6KinNnUKH0lETN77TcdQVc8=; b=V/q3DzvgufjxDa58+2tb/9346oMVQJ5o+JVaiRT9v+93hoIrA9dA9dPupkf5JTGEdhby2p TByRw+hwjqHJGosv4YFdgPscBpZvHfwjH8ulifoeVkIMijv9jU0bs0LNo0I11h2MhTQ0WE ySVLxzhl6oDGQ6Lb6CF3ch2N5i72b7Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-61-RAkrEywtN_-NiguQmprqGw-1; Tue, 21 Dec 2021 11:12:08 -0500 X-MC-Unique: RAkrEywtN_-NiguQmprqGw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A5E5D1006AAA; Tue, 21 Dec 2021 16:12:04 +0000 (UTC) Received: from localhost (unknown [10.39.193.154]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 474AF5BE0A; Tue, 21 Dec 2021 16:12:00 +0000 (UTC) From: Cornelia Huck To: Thomas Huth , qemu-devel@nongnu.org, qemu-s390x@nongnu.org Subject: Re: [PATCH RFC] MAINTAINERS: split out s390x sections In-Reply-To: <894b455c-6366-8cce-e11a-637d5f3d80e8@redhat.com> Organization: Red Hat GmbH References: <20211220115419.308463-1-cohuck@redhat.com> <894b455c-6366-8cce-e11a-637d5f3d80e8@redhat.com> User-Agent: Notmuch/0.34 (https://notmuchmail.org) Date: Tue, 21 Dec 2021 17:11:58 +0100 Message-ID: <87k0fy2b01.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.129.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.203, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Halil Pasic , Eric Farman , Christian Borntraeger , Richard Henderson , David Hildenbrand Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Dec 21 2021, Thomas Huth wrote: > On 20/12/2021 12.54, Cornelia Huck wrote: >> Split out some more specialized devices etc., so that we can build >> smarter lists of people to be put on cc: in the future. >> >> Signed-off-by: Cornelia Huck >> --- >> >> As discussed offlist. Some notes: >> - The new sections have inherited the maintainers of the sections >> they have been split out of (except where people had already >> volunteered). That's easy to change, obviously, and I hope that >> the cc: list already contains people who might have interest in >> volunteering for some sections. >> - I may not have gotten the F: patterns correct, please double check. >> - I'm also not sure about where in the MAINTAINERS file the new >> sections should go; if you have a better idea, please speak up. >> - Also, if you have better ideas regarding the sections, please >> speak up as well :) >> - Pull requests will probably continue the same way as now (i.e. >> patches picked up at the top level and then sent, except for some >> things like tcg which may go separately.) Not sure if it would >> make sense to try out the submaintainer pull request model again, >> I don't think it made life easier in the past, and now we have >> the b4 tool to pick patches easily anyway. It might be a good >> idea to check which of the tree locations should stay, or if we >> want to have new ones. >> >> --- >> MAINTAINERS | 86 ++++++++++++++++++++++++++++++++++++++++++++++------- >> 1 file changed, 75 insertions(+), 11 deletions(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 9a8d1bdf727d..d1916f075386 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -297,7 +297,6 @@ M: David Hildenbrand >> S: Maintained >> F: target/s390x/ >> F: target/s390x/tcg >> -F: target/s390x/cpu_models_*.[ch] >> F: hw/s390x/ >> F: disas/s390.c >> F: tests/tcg/s390x/ >> @@ -396,16 +395,10 @@ M: Halil Pasic >> M: Christian Borntraeger >> S: Supported >> F: target/s390x/kvm/ >> -F: target/s390x/ioinst.[ch] >> F: target/s390x/machine.c >> F: target/s390x/sigp.c >> -F: target/s390x/cpu_features*.[ch] >> -F: target/s390x/cpu_models.[ch] >> F: hw/s390x/pv.c >> F: include/hw/s390x/pv.h >> -F: hw/intc/s390_flic.c >> -F: hw/intc/s390_flic_kvm.c >> -F: include/hw/s390x/s390_flic.h >> F: gdb-xml/s390*.xml >> T: git https://github.com/borntraeger/qemu.git s390-next >> L: qemu-s390x@nongnu.org >> @@ -1529,12 +1522,8 @@ S390 Virtio-ccw >> M: Halil Pasic >> M: Christian Borntraeger >> S: Supported >> -F: hw/char/sclp*.[hc] >> -F: hw/char/terminal3270.c >> F: hw/s390x/ >> F: include/hw/s390x/ >> -F: hw/watchdog/wdt_diag288.c >> -F: include/hw/watchdog/wdt_diag288.h >> F: configs/devices/s390x-softmmu/default.mak >> F: tests/avocado/machine_s390_ccw_virtio.py >> T: git https://github.com/borntraeger/qemu.git s390-next >> @@ -1559,6 +1548,80 @@ F: hw/s390x/s390-pci* >> F: include/hw/s390x/s390-pci* >> L: qemu-s390x@nongnu.org >> >> +S390 channel subsystem >> +M: Halil Pasic >> +M: Christian Borntraeger >> +S: Supported >> +F: hw/s390x/ccw-device.[ch] >> +F: hw/s390x/css.c >> +F: hw/s390x/css-bridge.c >> +F: include/hw/s390x/css.h >> +F: include/hw/s390x/css-bridge.h >> +F: include/hw/s390x/ioinst.h >> +F: target/s390x/ioinst.c >> +L: qemu-s390x@nongnu.org >> + >> +3270 device >> +M: Halil Pasic >> +M: Christian Borntraeger >> +S: Odd fixes >> +F: include/hw/s390x/3270-ccw.h >> +F: hw/char/terminal3270.c >> +F: hw/s390x/3270-ccw.c >> +L: qemu-s390x@nongnu.org > > I'm a little bit torn between putting the s390x-related devices here in the > "Machine" section (which should rather be used for machines and not for > devices), or in the more generic "Devices" section later in the MAINTAINERS > file. We already have vfio-ccw and vfio-ap in the "Devices" section, so > maybe we should put the other s390x-related devices there as well? (maybe > with a "s390x" prefix so that they show up in the same spot if we sort them > alphabetically?) We also have virtio-ccw there already. (I'm not sure whether the "Devices" section is actually supposed to be ordered alphabetically; if it is, I think it would need some reordering effort.) For clarity, we could still add an S390 prefix here... > >> +diag 288 watchdog >> +M: Halil Pasic >> +M: Christian Borntraeger >> +S: Supported >> +F: hw/watchdog/wdt_diag288.c >> +F: include/hw/watchdog/wdt_diag288.h >> +L: qemu-s390x@nongnu.org ...and here. >> + >> +S390 CPU models >> +M: David Hildenbrand >> +S: Maintained >> +F: target/s390x/cpu_features*.[ch] >> +F: target/s390x/cpu_models.[ch] >> +L: qemu-s390x@nongnu.org This one was hard to fit, because it spans tcg and kvm, so we should probably keep it here. >> + >> +S390 storage key device >> +M: Halil Pasic >> +M: Christian Borntraeger >> +S: Supported >> +F: hw/s390x/storage-keys.h >> +F: hw/390x/s390-skeys*.c >> +L: qemu-s390x@nongnu.org >> + >> +S390 storage attribute device >> +M: Halil Pasic >> +M: Christian Borntraeger >> +S: Supported >> +F: hw/s390x/storage-attributes.h >> +F: hw/s390/s390-stattrib*.c >> +L: qemu-s390x@nongnu.org These two could go to the devices section. >> + >> +S390 SCLP-backed devices >> +M: Halil Pasic >> +M: Christian Borntraeger >> +S: Supported >> +F: include/hw/s390x/event-facility.h >> +F: include/hw/s390x/sclp.h >> +F: hw/char/sclp*.[hc] >> +F: hw/s390x/event-facility.c >> +F: hw/s390x/sclp*.c >> +L: qemu-s390x@nongnu.org I'd rather keep this one here, as it contains not only the console devices, but also the whole infrastructure. (Hmm, maybe call this "devices and infrastructure"? ) >> + >> +S390 floating interrupt controller >> +M: Halil Pasic >> +M: Christian Borntraeger >> +M: David Hildenbrand >> +S: Supported >> +F: hw/intc/s390_flic.c >> +F: hw/intc/s390_flic_kvm.c > > The above two lines could be shortened to: > > F: hw/intc/s390_flic*.c Yeah, this was simple cut-and-paste :) (This section could also move.) > >> +F: include/hw/s390x/s390_flic.h >> +L: qemu-s390x@nongnu.org >> + >> X86 Machines >> ------------ >> PC >> @@ -1957,6 +2020,7 @@ M: Halil Pasic >> S: Supported >> F: hw/s390x/virtio-ccw*.[hc] >> F: hw/s390x/vhost-vsock-ccw.c >> +F: hw/s390x/vhost-user-fs-ccw.c >> T: git https://gitlab.com/cohuck/qemu.git s390-next >> T: git https://github.com/borntraeger/qemu.git s390-next >> L: qemu-s390x@nongnu.org > > I'm also fine with this patch without further modifications, so: > > Acked-by: Thomas Huth Thanks! Any objections if I move the sections as outlined above and keep the acks I already have?