From: "Alex Bennée" <alex.bennee@linaro.org>
To: Jean-Christophe DUBOIS <jcd@tribudubois.net>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: Qemu and ARM secure state.
Date: Mon, 08 Nov 2021 14:14:45 +0000 [thread overview]
Message-ID: <87k0hik9yc.fsf@linaro.org> (raw)
In-Reply-To: <e0a1b786-4b1c-c608-495b-3fb839de2376@tribudubois.net>
Jean-Christophe DUBOIS <jcd@tribudubois.net> writes:
> One small question/remark:
>
> According to the the "Arm Power State Coordinate Interface" (DEN0022D.b) document (chapter 5) PSCI calls can only be issued by
> "normal world" (EL1 or EL2). Therefore, should we be adding a test for the current secure state in the arm_is_psci_call() function? This
> would prevent calling the built-in Qemu PSCI function if SMC is issued
> from secure state.
All that should be handled in:
void HELPER(pre_smc)(CPUARMState *env, uint32_t syndrome)
which should cause things to be trapped if the CPU is in an invalid
state to execute the SMC instruction. If the exception is a valid SMC we
end up in arm_cpu_do_interrupt where we may divert to
arm_handle_psci_call.
--
Alex Bennée
next prev parent reply other threads:[~2021-11-08 14:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <07e63acb-b756-2586-2ba2-b54b837f7fc8@tribudubois.net>
2021-11-04 11:11 ` Qemu and ARM secure state Peter Maydell
2021-11-04 21:11 ` Jean-Christophe DUBOIS
2021-11-06 10:04 ` Jean-Christophe DUBOIS
2021-11-06 13:04 ` Jean-Christophe DUBOIS
2021-11-06 18:11 ` Jean-Christophe DUBOIS
2021-11-08 14:14 ` Alex Bennée [this message]
2021-11-08 22:06 ` Jean-Christophe DUBOIS
2021-11-08 14:50 ` Peter Maydell
2021-11-08 22:09 ` Jean-Christophe DUBOIS
2021-11-09 10:55 ` Peter Maydell
2021-11-09 19:06 ` Jean-Christophe DUBOIS
2021-11-09 19:20 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0hik9yc.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=jcd@tribudubois.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).