From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AE0AC433DB for ; Fri, 5 Feb 2021 18:26:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D402564E41 for ; Fri, 5 Feb 2021 18:26:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D402564E41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l85o6-0000ha-C2 for qemu-devel@archiver.kernel.org; Fri, 05 Feb 2021 13:26:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l84V7-0000Bc-Qd for qemu-devel@nongnu.org; Fri, 05 Feb 2021 12:02:37 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:46105) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l84V4-0004os-Gv for qemu-devel@nongnu.org; Fri, 05 Feb 2021 12:02:33 -0500 Received: by mail-wr1-x42f.google.com with SMTP id q7so8400667wre.13 for ; Fri, 05 Feb 2021 09:02:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=LdWgyO2zPb/JEQszL1uIIoVUIJQDmtTT27aFUt/yx6k=; b=QBzTVAAw6+l50YOzIZC+p4thsKcbrTt+3giNVMc8WmDrOExAnsYnUN5O2f7Ukl+qdi syw7xBL1HROBB2lOD4dIzocyhvItkwI9qAp3eq7DD3mBhixJOLQJhDsqZb/vMopndTeB +3XCplCci5DqWw1b7bLO0P3YdWBJLNSoKgCQ7+t8uXb2LYtPIO/m8AlQC/Vl08mxv3cO dL/Pmmr58pwEqd25E4D8ZkLpjHYZwF11UDIvfJ1F+yANyErODiEZO8ZBi6m2blFCOVWl LSrAM0BgSfEUYE0A8++xGBhyAmOAsZHmd8cTOKjp72d6KIVdD7hGy6S2gdef0LnDojj5 M0/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=LdWgyO2zPb/JEQszL1uIIoVUIJQDmtTT27aFUt/yx6k=; b=JnkhLgBMpDELOaDlyJ8RkxsYGTn6dvMZwCM/2xMikbRMdmUHimnEV4EedfzB2neMMq xqp1eoHW5ubQ65Slf6FfMyeXWh9p/sTxqOhU8b0f6AldxGU4lHyH13ENclblCJN3xgIB 9S5hyvsauk7Vuzsasp1bHzKcqpP1vJ1ln3X3cLBzn4G3/uY0Eu7Ealov5mn/Es7MQ5nJ zrbMkjnIKVj0lXHUmhE5PogjKak8RRXGLx+4X078ak5+lYcMQNYnjImUZ1iEVuBPYvRJ qMLprWiL07U4ZFYYJIHt7o8BWzKsM/S8Qf4J9n3+ROd721qU8+EJIZ1TINPSpBpX/bbs iOvA== X-Gm-Message-State: AOAM531Q/ASwGqLVMHMgtrLXae7bCwph9wcWRCPLGOGxaKVARfLl7qKH OgTnYuuiRsAHLxaBlI1SNYDmJYA2rda2ximF X-Google-Smtp-Source: ABdhPJySJ/ScRmqN/pIebC9hYfjoBx/0m//72+HkA4rQeeMbEugklprOdJOtHSFesHaTN0dOehYqnQ== X-Received: by 2002:adf:cd10:: with SMTP id w16mr6051228wrm.90.1612544547736; Fri, 05 Feb 2021 09:02:27 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id w14sm13048740wro.86.2021.02.05.09.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 09:02:26 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id DB8DC1FF7E; Fri, 5 Feb 2021 17:02:25 +0000 (GMT) References: <20210205091857.845389-1-thuth@redhat.com> <20210205091857.845389-3-thuth@redhat.com> User-agent: mu4e 1.5.7; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Thomas Huth Subject: Re: [PATCH v2 2/5] travis.yml: Move the -fsanitize=undefined test to the gitlab-CI Date: Fri, 05 Feb 2021 16:59:50 +0000 In-reply-to: <20210205091857.845389-3-thuth@redhat.com> Message-ID: <87k0rmo3by.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Willian Rampazzo , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Thomas Huth writes: > Add it to the existing Clang job and also add a job that covers the > linux-user code with this compiler flag. To make sure that the detected > problems are not simply ignored, let's also use "-fno-sanitize-recover=3D= ..." > now instead. > > Signed-off-by: Thomas Huth > --- > .gitlab-ci.yml | 14 ++++++++++++-- > .travis.yml | 27 --------------------------- > 2 files changed, 12 insertions(+), 29 deletions(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 1070efce3f..1419eb4825 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -433,13 +433,23 @@ build-some-softmmu-plugins: > TARGETS: xtensa-softmmu arm-softmmu aarch64-softmmu alpha-softmmu > MAKE_CHECK_ARGS: check-tcg >=20=20 > -build-clang: > +clang-system: > <<: *native_build_job_definition > variables: > IMAGE: fedora > CONFIGURE_ARGS: --cc=3Dclang --cxx=3Dclang++ > + --extra-cflags=3D-fno-sanitize-recover=3Dundefined > TARGETS: alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu > - ppc-softmmu s390x-softmmu arm-linux-user > + ppc-softmmu s390x-softmmu > + MAKE_CHECK_ARGS: check-qtest check-block check-tcg > + > +clang-user: > + <<: *native_build_job_definition > + variables: > + IMAGE: fedora > + CONFIGURE_ARGS: --cc=3Dclang --cxx=3Dclang++ --disable-system > + --target-list-exclude=3Dmicroblazeel-linux-user,aarch64-linux-user= ,armeb-linux-user,x86_64-linux-user,mipsn32el-linux-user,xtensa-linux-user > + --extra-cflags=3D-fno-sanitize-recover=3Dundefined > MAKE_CHECK_ARGS: check Interesting choice of things to skip. I don't think we'll get much coverage though as check-tcg is about the only thing that exercises linux-user to any degree and you'll want to include arches the build system can build binaries for (arguably we should also update check-tcg to build for ^endian variants of the main targets). >=20=20 > # These targets are on the way out > diff --git a/.travis.yml b/.travis.yml > index 05fa1ca905..533a60c130 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -138,33 +138,6 @@ jobs: > - CACHE_NAME=3D"${TRAVIS_BRANCH}-linux-gcc-default" >=20=20 >=20=20 > - # Test with Clang for compile portability (Travis uses clang-5.0) > - - name: "Clang (user)" > - env: > - - CONFIG=3D"--disable-system --host-cc=3Dclang --cxx=3Dclang++" > - - CACHE_NAME=3D"${TRAVIS_BRANCH}-linux-clang-default" > - compiler: clang > - > - > - - name: "Clang (main-softmmu)" > - env: > - - CONFIG=3D"--target-list=3D${MAIN_SOFTMMU_TARGETS} > - --host-cc=3Dclang --cxx=3Dclang++" > - - CACHE_NAME=3D"${TRAVIS_BRANCH}-linux-clang-sanitize" > - compiler: clang > - before_script: > - - mkdir -p ${BUILD_DIR} && cd ${BUILD_DIR} > - - ${SRC_DIR}/configure ${CONFIG} --extra-cflags=3D"-fsanitize=3D= undefined -Werror" || { cat config.log meson-logs/meson-log.txt && exit 1; } > - > - > - - name: "Clang (other-softmmu)" > - env: > - - CONFIG=3D"--disable-user --target-list-exclude=3D${MAIN_SOFTMM= U_TARGETS} > - --host-cc=3Dclang --cxx=3Dclang++" > - - CACHE_NAME=3D"${TRAVIS_BRANCH}-linux-clang-default" > - compiler: clang > - > - > # Using newer GCC with sanitizers > - name: "GCC9 with sanitizers (softmmu)" > dist: bionic --=20 Alex Benn=C3=A9e