From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A284AC43461 for ; Fri, 4 Sep 2020 08:11:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C6E2206A5 for ; Fri, 4 Sep 2020 08:11:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C6E2206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE6oR-0004xW-J3 for qemu-devel@archiver.kernel.org; Fri, 04 Sep 2020 04:11:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kE6ns-0004RB-HQ for qemu-devel@nongnu.org; Fri, 04 Sep 2020 04:10:36 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:32368 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kE6nq-00027m-11 for qemu-devel@nongnu.org; Fri, 04 Sep 2020 04:10:35 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-504-DECNKf5VPhCR12LNDqMOXw-1; Fri, 04 Sep 2020 04:10:30 -0400 X-MC-Unique: DECNKf5VPhCR12LNDqMOXw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7D45087137B; Fri, 4 Sep 2020 08:10:29 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-113-68.ams2.redhat.com [10.36.113.68]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 345C51A914; Fri, 4 Sep 2020 08:10:29 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id AA2D01132B59; Fri, 4 Sep 2020 10:10:27 +0200 (CEST) From: Markus Armbruster To: Peter Maydell Subject: Re: [PATCH v5 06/20] tests/qapi/doc-good.json: Prepare for qapi-doc Sphinx extension References: <20200810195019.25427-1-peter.maydell@linaro.org> <20200810195019.25427-7-peter.maydell@linaro.org> Date: Fri, 04 Sep 2020 10:10:27 +0200 In-Reply-To: <20200810195019.25427-7-peter.maydell@linaro.org> (Peter Maydell's message of "Mon, 10 Aug 2020 20:50:05 +0100") Message-ID: <87k0xac68c.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=205.139.110.61; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/04 01:57:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Peter Maydell writes: > doc-good.json tests doc comment parser corner cases. We're about to > largely replace it by a Sphinx extension, which will have different > corner cases. Tweak the test so it passes both with the old parser > and the Sphinx extension, by making it match the more restrictive > rST syntax: > > * in a single list the bullet types must all match > * lists must have leading and following blank lines > * indentation is important Actually, indentation has always been important, but the conversion to rST changes where and how it matters. Perhaps: * the rules on when and where indentation matters differ > * the '|' example syntax is going to go away entirely, so stop > testing it > > This will avoid the tests spuriously breaking when we tighten up the > parser code in the following commits. > > Reviewed-by: Richard Henderson > Reviewed-by: Markus Armbruster > Signed-off-by: Peter Maydell