From: "Alex Bennée" <alex.bennee@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH 2/2] scripts/tracetool: Add plainlog backend
Date: Wed, 17 Jun 2020 16:41:04 +0100 [thread overview]
Message-ID: <87k105wvhr.fsf@linaro.org> (raw)
In-Reply-To: <20200617134505.9D06E7482D3@zero.eik.bme.hu>
BALATON Zoltan <balaton@eik.bme.hu> writes:
Did this patch get separated from a larger series (2/2)?
> Add a backend that is the same as the log backend but omits the
> process id and timestamp so logs are easier to read and diff-able.
I'd argue for this to be the behaviour of plain log (given it's mixing
with other log output). If not then maybe plainlog would be the default
log type if nothing is passed to configure?
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> scripts/tracetool/backend/plainlog.py | 48 +++++++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100644 scripts/tracetool/backend/plainlog.py
>
> diff --git a/scripts/tracetool/backend/plainlog.py b/scripts/tracetool/backend/plainlog.py
> new file mode 100644
> index 0000000000..40bbfa6d76
> --- /dev/null
> +++ b/scripts/tracetool/backend/plainlog.py
> @@ -0,0 +1,48 @@
> +# -*- coding: utf-8 -*-
> +
> +"""
> +Stderr built-in backend, plain log without proc ID and time.
> +"""
> +
> +__author__ = "Lluís Vilanova <vilanova@ac.upc.edu>"
> +__copyright__ = "Copyright 2012-2017, Lluís Vilanova <vilanova@ac.upc.edu>"
> +__license__ = "GPL version 2 or (at your option) any later version"
> +
> +__maintainer__ = "Stefan Hajnoczi"
> +__email__ = "stefanha@linux.vnet.ibm.com"
> +
> +
> +from tracetool import out
> +
> +
> +PUBLIC = True
> +
> +
> +def generate_h_begin(events, group):
> + out('#include "qemu/log-for-trace.h"',
> + '')
> +
> +
> +def generate_h(event, group):
> + argnames = ", ".join(event.args.names())
> + if len(event.args) > 0:
> + argnames = ", " + argnames
> +
> + if "vcpu" in event.properties:
> + # already checked on the generic format code
> + cond = "true"
> + else:
> + cond = "trace_event_get_state(%s)" % ("TRACE_" + event.name.upper())
> +
> + out(' if (%(cond)s && qemu_loglevel_mask(LOG_TRACE)) {',
> + ' qemu_log("%(name)s " %(fmt)s "\\n" %(argnames)s);',
> + ' }',
> + cond=cond,
> + name=event.name,
> + fmt=event.fmt.rstrip("\n"),
> + argnames=argnames)
> +
> +
> +def generate_h_backend_dstate(event, group):
> + out(' trace_event_get_state_dynamic_by_id(%(event_id)s) || \\',
> + event_id="TRACE_" + event.name.upper())
--
Alex Bennée
next prev parent reply other threads:[~2020-06-17 15:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 13:36 [PATCH 2/2] scripts/tracetool: Add plainlog backend BALATON Zoltan
2020-06-17 15:41 ` Alex Bennée [this message]
2020-06-17 17:53 ` BALATON Zoltan
2020-06-18 7:31 ` Stefan Hajnoczi
2020-06-18 9:07 ` Daniel P. Berrangé
2020-06-18 10:30 ` BALATON Zoltan
2020-06-18 15:35 ` Stefan Hajnoczi
2020-06-18 15:43 ` Daniel P. Berrangé
2020-06-23 14:47 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k105wvhr.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).