qemu-project git server not utf-8 clean?

qemu-project git server not utf-8 clean?

[Alex Bennée]

Hi,

I was doing some housekeeping of the wiki links into the docs page and I
discovered my name getting corrupted for:

  https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/devel/tcg-plugins.rst;hb=HEAD

Looking at the headers:

  HTTP/1.1 200 OK
  Date: Mon, 16 Dec 2019 16:24:50 GMT
  Server: Apache/2.4.6 (CentOS) OpenSSL/1.0.2k-fips PHP/5.4.16
  Content-disposition: inline; filename="docs/devel/tcg-plugins.rst"
  Keep-Alive: timeout=5, max=100
  Connection: Keep-Alive
  Transfer-Encoding: chunked
  Content-Type: text/plain; charset=ISO-8859-1

Shouldn't we (Apache/gitweb?) be passing UTF-8 contents?

-- 
Alex Bennée

Re: qemu-project git server not utf-8 clean?

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 968 bytes --]

On Mon, Dec 16, 2019 at 04:29:46PM +0000, Alex Bennée wrote:
> 
> Hi,
> 
> I was doing some housekeeping of the wiki links into the docs page and I
> discovered my name getting corrupted for:
> 
>   https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/devel/tcg-plugins.rst;hb=HEAD
> 
> Looking at the headers:
> 
>   HTTP/1.1 200 OK
>   Date: Mon, 16 Dec 2019 16:24:50 GMT
>   Server: Apache/2.4.6 (CentOS) OpenSSL/1.0.2k-fips PHP/5.4.16
>   Content-disposition: inline; filename="docs/devel/tcg-plugins.rst"
>   Keep-Alive: timeout=5, max=100
>   Connection: Keep-Alive
>   Transfer-Encoding: chunked
>   Content-Type: text/plain; charset=ISO-8859-1
> 
> Shouldn't we (Apache/gitweb?) be passing UTF-8 contents?

Strange, apache is configured to use UTF-8 by default and the gitweb
documentation indicates the web server default charset is used.

Anyway, it is fixed now.  I forced gitweb's charset by changing
/etc/gitweb.conf.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]