* [PATCH] configure: Remove s390 (31-bit mode) from the list of supported CPUs
@ 2019-09-28 19:03 Thomas Huth
2019-09-30 7:51 ` David Hildenbrand
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Thomas Huth @ 2019-09-28 19:03 UTC (permalink / raw)
To: Christian Borntraeger, qemu-s390x
Cc: Halil Pasic, Cornelia Huck, David Hildenbrand, qemu-devel,
Richard Henderson
On IBM Z, KVM in the kernel is only implemented for 64-bit mode, and
with regards to TCG, we also only support 64-bit host CPUs (see the
check at the beginning of tcg/s390/tcg-target.inc.c), so we should
remove s390 (without "x", i.e. the old 31-bit mode CPUs) from the
list of supported CPUs.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 397bb476e1..a4488c6705 100755
--- a/configure
+++ b/configure
@@ -728,7 +728,7 @@ ARCH=
# Normalise host CPU name and set ARCH.
# Note that this case should only have supported host CPUs, not guests.
case "$cpu" in
- ppc|ppc64|s390|s390x|sparc64|x32|riscv32|riscv64)
+ ppc|ppc64|s390x|sparc64|x32|riscv32|riscv64)
supported_cpu="yes"
;;
ppc64le)
--
2.18.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] configure: Remove s390 (31-bit mode) from the list of supported CPUs
2019-09-28 19:03 [PATCH] configure: Remove s390 (31-bit mode) from the list of supported CPUs Thomas Huth
@ 2019-09-30 7:51 ` David Hildenbrand
2019-09-30 7:59 ` Thomas Huth
2019-09-30 9:16 ` Alex Bennée
2019-09-30 10:25 ` Christian Borntraeger
2 siblings, 1 reply; 5+ messages in thread
From: David Hildenbrand @ 2019-09-30 7:51 UTC (permalink / raw)
To: Thomas Huth, Christian Borntraeger, qemu-s390x
Cc: Halil Pasic, Cornelia Huck, qemu-devel, Richard Henderson
On 28.09.19 21:03, Thomas Huth wrote:
> On IBM Z, KVM in the kernel is only implemented for 64-bit mode, and
> with regards to TCG, we also only support 64-bit host CPUs (see the
> check at the beginning of tcg/s390/tcg-target.inc.c), so we should
> remove s390 (without "x", i.e. the old 31-bit mode CPUs) from the
> list of supported CPUs.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 397bb476e1..a4488c6705 100755
> --- a/configure
> +++ b/configure
> @@ -728,7 +728,7 @@ ARCH=
> # Normalise host CPU name and set ARCH.
> # Note that this case should only have supported host CPUs, not guests.
> case "$cpu" in
> - ppc|ppc64|s390|s390x|sparc64|x32|riscv32|riscv64)
> + ppc|ppc64|s390x|sparc64|x32|riscv32|riscv64)
> supported_cpu="yes"
> ;;
> ppc64le)
>
Not sure if that ever worked
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] configure: Remove s390 (31-bit mode) from the list of supported CPUs
2019-09-30 7:51 ` David Hildenbrand
@ 2019-09-30 7:59 ` Thomas Huth
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2019-09-30 7:59 UTC (permalink / raw)
To: David Hildenbrand, Christian Borntraeger, qemu-s390x
Cc: Halil Pasic, Cornelia Huck, qemu-devel, Richard Henderson
On 30/09/2019 09.51, David Hildenbrand wrote:
> On 28.09.19 21:03, Thomas Huth wrote:
>> On IBM Z, KVM in the kernel is only implemented for 64-bit mode, and
>> with regards to TCG, we also only support 64-bit host CPUs (see the
>> check at the beginning of tcg/s390/tcg-target.inc.c), so we should
>> remove s390 (without "x", i.e. the old 31-bit mode CPUs) from the
>> list of supported CPUs.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 397bb476e1..a4488c6705 100755
>> --- a/configure
>> +++ b/configure
>> @@ -728,7 +728,7 @@ ARCH=
>> # Normalise host CPU name and set ARCH.
>> # Note that this case should only have supported host CPUs, not guests.
>> case "$cpu" in
>> - ppc|ppc64|s390|s390x|sparc64|x32|riscv32|riscv64)
>> + ppc|ppc64|s390x|sparc64|x32|riscv32|riscv64)
>> supported_cpu="yes"
>> ;;
>> ppc64le)
>>
>
> Not sure if that ever worked
I think it likely worked with dyngen (the predecessor of TCG), see
commit fb3e5849bb1 ... but I think it's broken since QEMU switched from
dyngen to TCG.
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] configure: Remove s390 (31-bit mode) from the list of supported CPUs
2019-09-28 19:03 [PATCH] configure: Remove s390 (31-bit mode) from the list of supported CPUs Thomas Huth
2019-09-30 7:51 ` David Hildenbrand
@ 2019-09-30 9:16 ` Alex Bennée
2019-09-30 10:25 ` Christian Borntraeger
2 siblings, 0 replies; 5+ messages in thread
From: Alex Bennée @ 2019-09-30 9:16 UTC (permalink / raw)
To: qemu-devel
Cc: David Hildenbrand, Cornelia Huck, Halil Pasic,
Christian Borntraeger, qemu-s390x, Richard Henderson
Thomas Huth <thuth@redhat.com> writes:
> On IBM Z, KVM in the kernel is only implemented for 64-bit mode, and
> with regards to TCG, we also only support 64-bit host CPUs (see the
> check at the beginning of tcg/s390/tcg-target.inc.c), so we should
> remove s390 (without "x", i.e. the old 31-bit mode CPUs) from the
> list of supported CPUs.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 397bb476e1..a4488c6705 100755
> --- a/configure
> +++ b/configure
> @@ -728,7 +728,7 @@ ARCH=
> # Normalise host CPU name and set ARCH.
> # Note that this case should only have supported host CPUs, not guests.
> case "$cpu" in
> - ppc|ppc64|s390|s390x|sparc64|x32|riscv32|riscv64)
> + ppc|ppc64|s390x|sparc64|x32|riscv32|riscv64)
> supported_cpu="yes"
> ;;
> ppc64le)
--
Alex Bennée
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] configure: Remove s390 (31-bit mode) from the list of supported CPUs
2019-09-28 19:03 [PATCH] configure: Remove s390 (31-bit mode) from the list of supported CPUs Thomas Huth
2019-09-30 7:51 ` David Hildenbrand
2019-09-30 9:16 ` Alex Bennée
@ 2019-09-30 10:25 ` Christian Borntraeger
2 siblings, 0 replies; 5+ messages in thread
From: Christian Borntraeger @ 2019-09-30 10:25 UTC (permalink / raw)
To: Thomas Huth, qemu-s390x
Cc: Halil Pasic, Cornelia Huck, David Hildenbrand, qemu-devel,
Richard Henderson
On 28.09.19 21:03, Thomas Huth wrote:
> On IBM Z, KVM in the kernel is only implemented for 64-bit mode, and
> with regards to TCG, we also only support 64-bit host CPUs (see the
> check at the beginning of tcg/s390/tcg-target.inc.c), so we should
> remove s390 (without "x", i.e. the old 31-bit mode CPUs) from the
> list of supported CPUs.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 397bb476e1..a4488c6705 100755
> --- a/configure
> +++ b/configure
> @@ -728,7 +728,7 @@ ARCH=
> # Normalise host CPU name and set ARCH.
> # Note that this case should only have supported host CPUs, not guests.
> case "$cpu" in
> - ppc|ppc64|s390|s390x|sparc64|x32|riscv32|riscv64)
> + ppc|ppc64|s390x|sparc64|x32|riscv32|riscv64)
> supported_cpu="yes"
> ;;
> ppc64le)
>
Thanks applied to s390-next.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-30 10:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-28 19:03 [PATCH] configure: Remove s390 (31-bit mode) from the list of supported CPUs Thomas Huth
2019-09-30 7:51 ` David Hildenbrand
2019-09-30 7:59 ` Thomas Huth
2019-09-30 9:16 ` Alex Bennée
2019-09-30 10:25 ` Christian Borntraeger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).